fix: resolve issues #197, #221, #523, #524#567
Merged
Conversation
, StellarYield#524 - Add docker-compose.test.yml for test DB - Add deposit-indexing.e2e.test.ts covering full pipeline: synthetic event → processEvent → user_vault_positions → portfolio API - Fix stellarAddressSchema regex off-by-one ({54} → {55}) so 56-char addresses pass validation - Install helmet@8.0.0 - Apply helmet() middleware in app.ts before routes - Add app.test.ts verifying X-Content-Type-Options and X-Frame-Options - Fix pre-existing lint errors in vaults.ts (unused caught errors) - Add test_emergency_withdraw_does_not_corrupt_yield_snapshots in test_escrow.rs: deposits, yield distribution, emergency_withdraw, then asserts pending_yield is unchanged for remaining users - Add test_transfer_mid_epoch_yield_split in test_token.rs: mid-epoch transfer, yield distribution, verify yield split matches snapshots - Add test_transfer_mid_epoch_snapshot_written_once: second transfer in same epoch does not overwrite the first snapshot
|
@devJaja Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #523
Closes #524
Closes #221
Closes #197
#523 — E2E test for deposit indexing flow
docker-compose.test.ymlfor test DBsrc/deposit-indexing.e2e.test.tscovering the full pipeline: synthetic deposit event →processEvent→user_vault_positions→GET /api/v1/users/:address/portfoliostellarAddressSchemaregex ({54}→{55}) that made all 56-char addresses fail validation#524 — Security headers via helmet
helmet@8.0.0helmet()inapp.tsbefore all routessrc/app.test.tsassertingX-Content-Type-Options: nosniffandX-Frame-OptionsonGET /healthvaults.ts(unused caught errors)#221 — Test emergency_withdraw not affecting yield snapshots
test_emergency_withdraw_does_not_corrupt_yield_snapshotsintest_escrow.rs: two users deposit, yield distributed, emergency_withdraw executed, assertspending_yieldis unchanged for both users#197 — Test share transfer during active epoch
test_transfer_mid_epoch_yield_splitintest_token.rs: mid-epoch transfer, yield distributed, yield split matches pre-transfer snapshotstest_transfer_mid_epoch_snapshot_written_once: second transfer in same epoch does not overwrite first snapshotTest results