Skip to content

test(backend): middleware tests, coverage thresholds & CI lint repair (#502-#505)#568

Open
jayteemoney wants to merge 5 commits into
StellarYield:mainfrom
jayteemoney:issue-502-505-backend-test-infra
Open

test(backend): middleware tests, coverage thresholds & CI lint repair (#502-#505)#568
jayteemoney wants to merge 5 commits into
StellarYield:mainfrom
jayteemoney:issue-502-505-backend-test-infra

Conversation

@jayteemoney
Copy link
Copy Markdown
Contributor

@jayteemoney jayteemoney commented May 29, 2026 •
edited
Loading

Summary

Closes #502, #503, #504, #505 — the backend test/CI-infrastructure issues — implemented against the real backend/ package on main.

Rebased onto the latest main, so it merges cleanly. (Earlier conflict in backend/package.json / package-lock.json — upstream added supertest/helmet at the same spot my commit added @vitest/coverage-v8 — is resolved by keeping all of them.)

Changes (per issue)

#502 — error handler tests (src/api/middleware/errors.test.ts)
Tests errorHandler: statusCode honoured (404/403), missing statusCode → 500, body always has error + message (with defaults).

#503 — validate tests (src/api/middleware/validate.test.ts)
Tests validateBody/validateQuery/validateParams: valid input calls next() with parsed data; invalid input returns 400 with an issues array and skips next().

#504 — Vitest coverage thresholds (vitest.config.ts, package.json)
Adds @vitest/coverage-v8, a test:coverage script, and threshold enforcement. The real backend is only ~40% covered, so a literal global 60 would fail immediately; thresholds are set as a regression ratchet just below current coverage (lines 35 / functions 38 / branches 55) and fail the run when coverage drops (verified). Non-testable code (entrypoints, migrations/seed, scripts, type-only modules) is excluded. Raise toward 60 as coverage grows.

#505 — backend lint in CI (.github/workflows/ci.yml)
main's ci.yml currently contains committed merge-conflict markers (from merge 3ca0297) — it is invalid YAML, so no CI runs at all. Reconstructed a single valid workflow (sdk, backend, fmt, clippy, test, build, all-checks-passed). The backend job runs npm run lint in backend/, failing the workflow on any lint error.

Why lint only (not build/test) in the backend job: both are pre-existing red on main, independent of this PR — src/services/indexer.ts references an undefined parseCancelFundingEvent / handleCancelFunding (half-merged "cancel funding" feature) so npm run build doesn't compile, and indexer.test.ts, vaults.test.ts, deposit-indexing.e2e.test.ts fail. Gating on them would make every PR red. The job is structured so build/test can be re-added once the backend compiles and its suite is green.

Prerequisite fix (fix(backend): unblock lint/build on pre-existing breakage)

Needed so the backend lint gate is green:

  • routes/vaults.ts imported getVault/getVaultPositions that no route uses → removed (failed no-unused-vars).
  • services/redemption-queue.test.ts was broken (import paths off by one level, type errors, ~9 failing assertions against a non-existent redemption-queue.ts). Fixed the paths, removed an unused import, quarantined its suites with describe.skip + a note, and excluded it from tsc.

Verification

cd backend && npm ci && npm run lint   # PASS (the CI gate)
npx vitest run src/api/middleware/      # 11 passed (the new #502/#503 tests)

Coverage threshold mechanism verified to fail on a coverage drop
(ERROR: Coverage for lines (...) does not meet global threshold (35%)).

Reviewer notes

  • Coverage thresholds are a deliberate ratchet, not literal 60 (backend can't meet 60 globally yet).
  • The ci.yml reconstruction fixes an existing breakage on main — worth a sanity check that the job set matches your intent.
  • redemption-queue.test.ts is quarantined, not fixed; the broader backend build/test failures (indexer cancel-funding) are pre-existing and out of scope here — likely each warrants its own issue.

Closes #502
Closes #503
Closes #504
Closes #505

@jayteemoney jayteemoney force-pushed the issue-502-505-backend-test-infra branch from 3a00ddc to d04dbc8 Compare May 30, 2026 07:05
@drips-wave
Copy link
Copy Markdown

drips-wave Bot commented May 30, 2026

@jayteemoney Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@jayteemoney jayteemoney changed the title test(backend): add error/validate middleware tests, coverage thresholds & CI lint test(backend): middleware tests, coverage thresholds & CI lint repair (#502-#505) May 30, 2026
@jayteemoney
fix(backend): unblock lint/build on pre-existing breakage
e12dfa8 
The backend was already failing `npm run lint` and `npm run build` on main
(masked because the CI workflow file itself was invalid — see the ci fix):

- routes/vaults.ts imported getVault/getVaultPositions, which are unused
  (no routes reference them) and failed no-unused-vars. Removed them.
- services/redemption-queue.test.ts had import paths off by one directory
  level (../../services -> ./, ../../db -> ../db) so it failed to load, plus
  type errors and ~9 failing assertions against a redemption-queue.ts module
  that does not exist. Fixed the import paths, removed an unused import, and
  quarantined every suite with describe.skip behind an explanatory note;
  excluded the file from the tsc build until it is repaired under its own issue.

This is the minimum needed so a backend lint/build/test gate can be green.
@jayteemoney
test(backend): add unit tests for error handler middleware
1ffc766 
Covers the errorHandler middleware (src/api/middleware/errors.ts):
- an error with statusCode 404 returns 404; an arbitrary statusCode is honoured
- an error without statusCode falls back to HTTP 500
- the JSON body includes both `error` and `message`, defaulting both when absent

Closes StellarYield#502
@jayteemoney
test(backend): add unit tests for validate middleware
d698c81 
Covers validateBody, validateQuery and validateParams (src/api/middleware/
validate.ts) with Zod schemas:
- valid input calls next() and forwards the parsed data
- invalid input returns HTTP 400 with an `issues` array and skips next()

Closes StellarYield#503
@jayteemoney
test(backend): add Vitest coverage thresholds
1864a1c 
Configures @vitest/coverage-v8 in vitest.config.ts and adds a "test:coverage"
script. Thresholds act as a regression ratchet set just below current coverage
(lines 35, functions 38, branches 55) so the run fails when coverage drops —
e.g. when a tested function is removed or new code lands untested. Non-testable
code (entrypoints, db migrations/seed, scripts, type-only modules) is excluded.
Raise the thresholds toward 60% as backend coverage improves.

Closes StellarYield#504
@jayteemoney
ci: repair workflow and add backend lint gate
ad89fbb 
The ci.yml on main contained committed merge-conflict markers (from merge
3ca0297), making it invalid YAML so no CI ran at all. Reconstructed a single
coherent workflow (sdk, backend, fmt, clippy, test, build, all-checks-passed).

The backend job runs in backend/ and executes `npm run lint`, failing the
workflow on any lint error (StellarYield#505). Backend build/test are intentionally left
out for now: they are pre-existing red on main (indexer.ts references an
undefined parseCancelFundingEvent/handleCancelFunding from a half-merged
feature, and several suites fail), so gating on them would make every PR red.

Closes StellarYield#505
@jayteemoney jayteemoney force-pushed the issue-502-505-backend-test-infra branch from d04dbc8 to ad89fbb Compare May 30, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

1 participant

@jayteemoney