Add support for additional VM tags - #61
Merged
Merged
Conversation
NocDerEchte
force-pushed
the
pve-vm-tags
branch
from
November 23, 2025 19:47
cfe4177 to
e304204
Compare
Signed-off-by: NocDerEchte <147306991+NocDerEchte@users.noreply.github.com>
Signed-off-by: NocDerEchte <147306991+NocDerEchte@users.noreply.github.com>
Signed-off-by: NocDerEchte <147306991+NocDerEchte@users.noreply.github.com>
Signed-off-by: NocDerEchte <147306991+NocDerEchte@users.noreply.github.com>
NocDerEchte
force-pushed
the
pve-vm-tags
branch
from
November 23, 2025 20:02
e304204 to
dc52e6f
Compare
Signed-off-by: NocDerEchte <147306991+NocDerEchte@users.noreply.github.com>
keyaray
reviewed
Dec 1, 2025
keyaray
left a comment
Contributor
There was a problem hiding this comment.
Looks great! I'll test it tomorrow.
keyaray
approved these changes
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The option for adding tags to the created VMs would help when managing the VMs in PVE and tools like ProxLB could use the added tags to ensure that, for example, control-plane nodes get scheduled on different nodes to ensure high-availability even if one PVE node fails.
There is also an Issue (#51) that requested this feature.
I hope that my additions make sense and the code is somewhat good. My go experience is pretty limited.
If I forgot something to add, feel free to point it out.
Thanks!
PS.: You did a great job building this tool, keep up the good work!
How Has This Been Tested?
Everything worked and the tags were added to the created VMs. Including the "old" tag "docker-machine".
Checklist