Skip to content

Add support for additional VM tags - #61

Merged
keyaray merged 5 commits into
Stellatarum:mainfrom
NocDerEchte:pve-vm-tags
Dec 2, 2025
Merged

Add support for additional VM tags#61
keyaray merged 5 commits into
Stellatarum:mainfrom
NocDerEchte:pve-vm-tags

Conversation

@NocDerEchte

Copy link
Copy Markdown
Contributor

Description

The option for adding tags to the created VMs would help when managing the VMs in PVE and tools like ProxLB could use the added tags to ensure that, for example, control-plane nodes get scheduled on different nodes to ensure high-availability even if one PVE node fails.

There is also an Issue (#51) that requested this feature.

I hope that my additions make sense and the code is somewhat good. My go experience is pretty limited.

If I forgot something to add, feel free to point it out.

Thanks!

PS.: You did a great job building this tool, keep up the good work!

How Has This Been Tested?

  • Installed Extension via Rancher
  • Deployed test-cluster with added tags

Everything worked and the tags were added to the created VMs. Including the "old" tag "docker-machine".

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Signed-off-by: NocDerEchte <147306991+NocDerEchte@users.noreply.github.com>
Signed-off-by: NocDerEchte <147306991+NocDerEchte@users.noreply.github.com>
Signed-off-by: NocDerEchte <147306991+NocDerEchte@users.noreply.github.com>
Signed-off-by: NocDerEchte <147306991+NocDerEchte@users.noreply.github.com>
Signed-off-by: NocDerEchte <147306991+NocDerEchte@users.noreply.github.com>

@keyaray keyaray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I'll test it tomorrow.

@keyaray
keyaray merged commit 9e561c4 into Stellatarum:main Dec 2, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants