fix: set ip address in driver struct - #71
Open
mqufflc wants to merge 1 commit into
Open
Conversation
Signed-off-by: mqufflc <94301322+mqufflc@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
At the moment, it is not possible to SSH to a VM created by the pve driver directly from Rancher Web Interface. See #62.
This pull request fixes this bug by setting the IPAddress or IPv6Address in the driver struct when calling GetIP().
This will set the IP address in the secret Rancher populates after the VM is provisioned.
How Has This Been Tested?
I tested this manually against a proxmox cluster.
I just replaced the binary on an already deployed driver and I was able to SSH to a VM.
Checklist