Skip to content

fix: set ip address in driver struct - #71

Open
mqufflc wants to merge 1 commit into
Stellatarum:mainfrom
mqufflc:main
Open

fix: set ip address in driver struct#71
mqufflc wants to merge 1 commit into
Stellatarum:mainfrom
mqufflc:main

Conversation

@mqufflc

@mqufflc mqufflc commented May 11, 2026

Copy link
Copy Markdown

Description

At the moment, it is not possible to SSH to a VM created by the pve driver directly from Rancher Web Interface. See #62.
This pull request fixes this bug by setting the IPAddress or IPv6Address in the driver struct when calling GetIP().

This will set the IP address in the secret Rancher populates after the VM is provisioned.

How Has This Been Tested?

I tested this manually against a proxmox cluster.
I just replaced the binary on an already deployed driver and I was able to SSH to a VM.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Signed-off-by: mqufflc <94301322+mqufflc@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant