Making /dc giveback give back items like how you normally get your items back - #97
Open
retrorandom wants to merge 2 commits into
Open
Making /dc giveback give back items like how you normally get your items back#97retrorandom wants to merge 2 commits into
retrorandom wants to merge 2 commits into
Conversation
…e give back command puts your armour back on and if you had a offhand item it goes back there as well.
Member
|
Hi thanks for your PR ! Good job. Sorry for the delay. Love the idea. Can you make it configurable through the config.yml file ? Like giveBackAutoEquip: true/false Thanks ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The /dc giveback command now returns people's items just as before they died and It will return all there items to the right slots including armour slots, offhand slot and Inventory slots.
Reason for this PR: When that command is used It may be hard for players to find there items if it is just on the ground around them.
Also bumped the version from
4.23.0to4.23.1If you need this changed just say so.If there is any concern with anything made here just ask for it to be changed or just close this PR.
Thank you for reading and I hope you have a wonderful rest of your day!! 💜💜
also this is my first PR ever and I haven't really worked with modern Bukkit / Spigot so feedback is greatly appreciated lol
Tests: