Repository navigation
fix(replay): refuse missing regression directories - #411
Merged
Merged
Conversation
Fixes #307 what changed: property-replay --all refuses a missing directory as INCOMPLETE with exit 2, names its path and remedy, and explicitly describes an existing empty directory. JSON directory results include the path and regression count. Add one regression covering text/JSON refusals, empty results and read-only behavior. why: A missing regression directory previously reported PASS (0), hiding a typo or incomplete checkout. The obvious remedy is a CLI refusal and explicit empty result; no alternative design was set aside. what it touched: research-kit/bin/property-replay.mjs, its test file, the replay seam in docs/ARCHITECTURE.md, research-kit/README.md and CHANGELOG.md. The library's listing contract and captured evidence are unchanged; the suite inventory is 1,836. what you verified: verified - the new CLI regression failed on the current main baseline (4 passed, 1 failed), then all five property-replay tests passed after correction. Missing and empty directories remain unmodified. The normal commit gate runs the complete offline suite before accepting this commit; GitHub CI will verify the published head before merge. what you got wrong and fixed: nothing to report.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A missing regression directory previously made
property-replay --allprintPASS (0)and exit successfully. It now reportsINCOMPLETEwith exit 2 and a named path/remedy; an existing empty directory explicitly says no regressions were captured. JSON directory results carry the path and count.Fixes #307
what changed: property-replay --all refuses a missing directory as INCOMPLETE with exit 2, names its path and remedy, and explicitly describes an existing empty directory. JSON directory results include the path and regression count. Add one regression covering text/JSON refusals, empty results and read-only behavior.
why: A missing regression directory previously reported PASS (0), hiding a typo or incomplete checkout. The obvious remedy is a CLI refusal and explicit empty result; no alternative design was set aside.
what it touched: research-kit/bin/property-replay.mjs, its test file, the replay seam in docs/ARCHITECTURE.md, research-kit/README.md and CHANGELOG.md. The library's listing contract and captured evidence are unchanged; the suite inventory is 1,836.
what you verified: verified - the new CLI regression failed on the current main baseline (4 passed, 1 failed), then all five property-replay tests passed after correction. Missing and empty directories remain unmodified. The normal full-suite commit gate accepted e71077b on Windows / Node 24.20.0, with its documented local unsupported-capability allowance. The README inventory is 1,836. GitHub CI will verify the published head on its supported platforms before merge.
what you got wrong and fixed: nothing to report.