Repository navigation
fix: enforce the positive decompose search limit - #419
Merged
Merged
Conversation
what changed Aligned decompose's CLI --limit floor with the library's positive whole-number requirement. Regression coverage refuses zero, negative and nonnumeric limits and accepts limit one with max-scrapes zero. Updated the architecture map, changelog and test inventory. why Fixes #320. The CLI claimed a minimum of zero while the library refused zero. The existing library guard remains; max-scrapes still permits zero. what it touched research-kit/bin/decompose.mjs, research-kit/test/cli.test.mjs, docs/ARCHITECTURE.md, CHANGELOG.md and research-kit/README.md. No new options or collection behavior. what you verified verified: before-fix probes showed the contradictory --limit abc and --limit 0 diagnostics. expected: the ordinary commit gate runs the full offline suite, including CLI and decompose coverage, and verifies the staged map and inventory. Final observed results accompany the PR. what you got wrong and fixed mistake: the first test insertion split an existing explanatory comment. where: research-kit/test/cli.test.mjs, before the new-project regression. impact: the comment was detached from its original test; no behavior or delivered change was affected. cause: the patch insertion matched only the first line of the comment. fix: moved the new limit-boundary test before the complete original comment. verified: reviewed the final placement and git diff --check passed; the normal gate covers the final test file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
decompose --limitnow consistently requires a whole number of at least 1. Zero, negative and nonnumeric limits are refused at the CLI boundary with the same real minimum;--max-scrapes 0remains supported.Fixes #320.
what changed
Aligned decompose's CLI --limit floor with the library's positive whole-number requirement. Regression coverage refuses zero, negative and nonnumeric limits and accepts limit one with max-scrapes zero. Updated the architecture map, changelog and test inventory.
why
Fixes #320. The CLI claimed a minimum of zero while the library refused zero. The existing library guard remains; max-scrapes still permits zero.
what it touched
research-kit/bin/decompose.mjs, research-kit/test/cli.test.mjs, docs/ARCHITECTURE.md, CHANGELOG.md and research-kit/README.md. No new options or collection behavior.
what you verified
verified: before-fix probes showed the contradictory --limit abc and --limit 0 diagnostics. verified: the normal git commit gate ran the full staged offline suite, including CLI and decompose coverage, and allowed commit 3b21051. The local gate permits unavailable capabilities under ADR-0108 and deletes their detailed totals. verified: all seven required CI jobs passed for head
3b2105123daf9a97ea735931c236ababb13e8975in offline-suite run #778. The completed Node 24 log reports 1,846 passed, 0 failed in 202.2s.what you got wrong and fixed
mistake: the initial test insertion split an existing comment. where: cli.test.mjs before the new-project regression. impact: comment placement only, no delivered behavior affected. cause: insertion matched one comment line. fix: moved the new test before the intact comment. verified: final placement reviewed and git diff --check passed.