v1.2.0 - Fixing 1.1.0 crash, enforcing use of discord channel, preventing discord echo, adding optional footer#3
Open
iuriguilherme wants to merge 5 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request bumps the version from 1.0.0 to 1.1.1 to address critical issues from v1.1.0: a crash when sending game messages and unwanted message replication from other Discord channels.
- Crash Fix: Added null pointer checks for
worldModuleandbotbefore attempting to send messages to Discord - Channel Validation: Implemented channel ID verification to ignore messages from unintended Discord channels
- Library Cleanup: Removed unused DPP library header files from the repository
Reviewed changes
Copilot reviewed 68 out of 79 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| FicsitChat.uplugin | Version bumped from 1.0.0 to 1.1.1 |
| Source/FicsitChat/FicsitChat.Build.cs | Added C++20 standard requirement |
| Source/FicsitChat/Private/FicsitChatModule.cpp | Added null pointer checks for bot and worldModule (lines 36-39) to prevent crashes |
| Source/FicsitChat/Private/FicsitChatWorldModule.cpp | Added channel ID validation (lines 46-48) to filter messages from other Discord channels |
| Source/ThirdParty/DPPLibrary/include/dpp/* | Removed 50+ unused header files for library cleanup |
| Binaries/Win64/*.dll | Updated DLL binaries (no diff available) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
added 2 commits
January 6, 2026 23:46
…ng, removed discord echo
iuriguilherme
changed the title
Contributor
Author
|
v1.2.0 adds:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v1.1.0 was causing a crash when sending game message in some circumstances because the mod was not checking whether some objects were properly initialized.
Bot was getting messages from other discord channels and replicating them in the configured discord channel as well as the game chat. A check has been placed to ensure the bot only parses messages from the intended channel, ignoring all other discord messages. This change is already part of the v1.2.0 upcoming pull request