Improvements and updates - #108
Open
barbieri wants to merge 12 commits into
Open
Conversation
Simplifies usage and bring it closer to actions/checkout and actions/github-script. See: https://github.com/actions/checkout/blob/main/action.yml#L24 https://github.com/actions/github-script/blob/main/action.yml#L13 Closes: Stockopedia#107
otherwise people must check the source code to find out it's 'newline' to get line breaks
The original typescript-action were used, fill in with actual values for this project.
This changed recently in tsc and is now fixed
also add some manual fixes required: - remove unused constructor in CommandFactory - add return type to FormatFactory.make
These were pointed out by newer tsc, no big deal but worth playing nice with the more strict checks.
Node16 is better handled by target es2021, see: https://github.com/microsoft/TypeScript/wiki/Node-Target-Mapping
This package will to run many npm scripts, be in parallel or serial, replacing previous '&&' of multiple 'npm run'. Also include 'lint' in 'all' script.
Updated built files since sources and tooling changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for your GitHub action. In retribution, please consider the following PR. It handles #107 and all the other dependabot PR since I'm updating all the libraries.
While doing so, newer typescript and eslint points more errors, they are all fixed.