fix: create runtime-donor snapshot whenever manifest is missing - #114
Merged
Merged
Conversation
When the installer reused an existing vanilla directory (the common case on reinstall and upgrade), freshExtract was false and skipDownload was false, so the snapshot-creation branch was never entered. Only a warning was emitted. prepare-runtime-donors.ps1 then threw 'Required runtime-donor input not found: runtime-donor-manifest.sha256' because the snapshot had never been written. Remove the skipDownload guard so the snapshot is created whenever the manifest is absent, regardless of how the vanilla directory was obtained.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the installer reused an existing vanilla directory (the common case on reinstall and upgrade), \ reshExtract\ and \skipDownload\ were both false, so the snapshot-creation branch in \�ootstrap.ps1\ was never entered. Only a warning was emitted. \prepare-runtime-donors.ps1\ then threw \Required runtime-donor input not found: runtime-donor-manifest.sha256\ because the snapshot had never been written.
The fix removes the \ -and\ guard from the condition so the snapshot is created whenever the manifest is absent, regardless of how the vanilla directory was obtained. \New-RuntimeDonorSnapshot\ is safe to call on any valid vanilla directory: it removes and recreates the snapshot dir cleanly, copies the DLLs, and has its own guard that throws if the vanilla dir already contains Optimum build output.
Fixes the failure reported with 0.3.17 on reinstall/upgrade scenarios.