ci: modernize GitHub Actions runners and resolve xUnit test warnings - #89
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modernizes GitHub Actions workflows across the repository to use current Node.js 24-compliant actions, updates the macOS installer build runner from retired
macos-13tomacos-14, and resolves all five xUnit analyzer warnings in the test suites.Key Changes
Test Suite Analyzer Cleanliness:
Optimum.Bootstrap.Core.Tests/PrerequisiteScannerTests.cs: replacedAssert.Emptyon.WherewithAssert.DoesNotContainto satisfyxUnit2029.Optimum.Cli.Tests/NdjsonStream.cs: replacedAssert.True(set.Contains(val))withAssert.Contains(val, set)to satisfyxUnit2017.Optimum.Installer.Tests/ScreenViewModelTests.cs: suppliedTestContext.Current.CancellationTokentoFile.WriteAllTextAsyncandTask.WaitAsyncto satisfyxUnit1051.Runner Modernization:
release-installer.yml, transitioned theosx-x64target runner from retiredmacos-13tomacos-14. .NET cross-compiles cleanly on Apple Silicon runners, avoiding indefinite queuing on retired runner images.Action Version Upgrades:
actions/checkoutto@v6.actions/setup-dotnetto@v6.actions/cacheto@v6.actions/upload-artifactto@v7.actions/download-artifactto@v8.Verification
dotnet test Optimum.Installer.slnf -c Release(245 passed, 0 failed, 0 warnings).yqlinting cleanly.make agent-check(PASS).