fix(installer): replace innounp with crazy-max/innoextract v1.13.0 - #91
Merged
Merged
Conversation
…ross platforms Inno Setup 6.4.3 archives fail to unpack with innounp (exit code 64). Migrate bootstrap and packaging scripts across Windows, Linux, and macOS to download and use crazy-max/innoextract v1.13.0 with SHA-256 validation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Vintage Story 1.22.7 and newer Windows installer packages use Inno Setup 6.4.3. The previous extraction tool (innounp) fails on Inno Setup 6.4 archives with exit code 64.
This change replaces innounp with crazy-max/innoextract v1.13.0 across all installer and bootstrap scripts.
Changes
scripts/bootstrap.ps1to download and run crazy-max/innoextract v1.13.0 on Windows and Unix with SHA-256 integrity verification.scripts/bootstrap.shto extract Windows installer executables via crazy-max/innoextract v1.13.0.scripts/_hostcaps.ps1andscripts/package.ps1to resolve.tools/innoextractor.tools/innoextract.exe.Optimum.Bootstrap.Core/Prerequisites/PrerequisiteScanner.csto detect.tools/innoextractin the repository root and home directory.Verification
Optimum.Tests: 731 passed, 0 failed, 34 skipped.Optimum.Installer.slnf: 245 passed, 0 failed.make agent-check: passed.git diff --check: passed.