Skip to content

Flaky test: Activity Center Escape case times out under CI load #504

Description

@Pixnop

Summary

tests/renderer-dom/activityCenter.test.tsx > "Activity Center keyboard reach" > "closes on Escape and hands focus back to the trigger" fails intermittently on the runners with AssertionError: expected <div role="region" ...> to be null, after taking more than 5 seconds. Reran on the same commit, it passes.

Why it matters

The failure takes the whole test-matrix leg red, which then fails the test aggregator and makes sonarcloud fail on a missing coverage artefact. Three red checks on a pull request that has nothing wrong with it, and a rerun every time.

Evidence

What to look at

The assertion waits for the region to disappear after Escape. The panel plays an exit animation, so the region survives the default 1 second waitFor when the runner is loaded, the way discardToast did before #428 raised its timeout to 5 seconds. Either wait for the element to be removed with a timeout sized on the animation, or assert on what Escape controls rather than on the node being gone. Check the sibling cases in that file for the same shape.

Acceptance

  • The case no longer depends on an animation finishing within an arbitrary window.
  • Ten consecutive runs of the file under CPU load stay green.
  • Any sibling case with the same shape gets the same treatment.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions