When not using deno.json, ensure latest glue-runtime is used#31
Conversation
Greptile SummaryThis PR adds Confidence Score: 5/5This PR is safe to merge; the only finding is a minor API cleanup suggestion (P2). All logic changes are straightforward and well-reasoned. The lib/runtimeVersionCheck.ts — the unused Important Files Changed
Reviews (1): Last reviewed commit: "use --reload flag to make sure latest ru..." | Re-trigger Greptile |
There was a problem hiding this comment.
Code Review
This pull request updates the dev command to ensure the latest version of the streak runtime is used by conditionally applying the --reload flag, particularly when a deno.json configuration is missing. The getOutdatedStreakRuntimeVersion function was refactored to accept configuration paths directly. Feedback suggests removing the unused _filename parameter from this function to simplify its signature.
|
|
||
| export async function getOutdatedStreakRuntimeVersion( | ||
| filename: string, | ||
| _filename: string, |
There was a problem hiding this comment.
The _filename parameter is no longer used within getOutdatedStreakRuntimeVersion because the configuration paths are now passed directly via the denoConfigPaths argument. Removing this unused parameter would simplify the function's signature. Note that call sites in commands/dev.ts and lib/runtimeVersionCheck.test.ts would also need to be updated to reflect this change.
Follow-up to #30, which applies specifically for Glues that have a deno.json and shows a warning message if an old glue-runtime is being used.
This PR applies to Glues without a deno.json. It causes us to run the user's glue with the right Deno flags to ensure unversioned glue-runtime imports use the latest version.