Fix Stream Deck Plus HID read length to match report descriptor#10
Open
callmepain wants to merge 1 commit intoStreamController:masterfrom
Open
Fix Stream Deck Plus HID read length to match report descriptor#10callmepain wants to merge 1 commit intoStreamController:masterfrom
callmepain wants to merge 1 commit intoStreamController:masterfrom
Conversation
The Stream Deck Plus USB HID report descriptor declares a 512-byte input report. Reading only 14 bytes worked with older HIDAPI versions, but HIDAPI 0.15.0 using the libusb backend silently drops reports when the requested size is smaller than the descriptor's report size. This causes dial TURN events to never arrive, while button presses (which appear in shorter reports) still work. Capturing raw HID data confirms 512-byte reads return all events correctly, whereas 14-byte reads return no data for dial rotations. Add a class constant _INPUT_REPORT_LEN = 512 (matching the HID report descriptor) and use it in _read_control_states() instead of the hard-coded 14-byte read. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_read_control_states()was reading only 14 bytes.Changes
_INPUT_REPORT_LEN = 512toStreamDeckPlus, matching the USB HID report descriptor.self.device.read(14)toself.device.read(self._INPUT_REPORT_LEN)in_read_control_states().Test plan