Repository navigation
total_ngos always returns 0 #264
Description
Summary
total_ngos() reads DataKey::TotalNgos, which nothing writes, so it always
returns 0, while ngo_count() returns the real value with a different type
(u64 against u32). Closed issue #9 added the counter; what is on main
doesn't work.
Acceptance criteria
- Remove
total_ngosandTotalNgos, or make it return the same value asngo_count. - Add a test that registers two NGOs and checks the count getter.
Getting started
Fork this repository, clone your fork, and add this repo as upstream:
git clone https://github.com/<your-username>/streamgive-contracts.git
cd streamgive-contracts
git remote add upstream https://github.com/StreamGive/streamgive-contracts.gitCreate a branch for this issue:
git checkout -b fix/registry-total-ngosSuggested commit message:
fix(ngo-registry): fix or remove total_ngos
Run cargo fmt --check, cargo clippy, and cargo test before pushing, then
open a pull request from your fork against main and link this issue. See
the contributing guide for the full contribution guide.
Activity
buki70 commentedon Oct 16, 2026
@buki70 has applied to work on this issue as part of the Stellar Wave Program's 10th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @buki70 to this issue.
Joyee730 commentedon Oct 16, 2026
@Joyee730 has applied to work on this issue as part of the Stellar Wave Program's 10th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @Joyee730 to this issue.
drips-wave commentedon Oct 16, 2026
Congratulations, @Joyee730! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on October 22, 2026.
🧑💻 @Joyee730: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.
Warning
When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.
🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.
🌊 Happy Wave 🌊
github-actions commentedon Oct 18, 2026
Closed by #329, which was merged automatically.