Skip to content

Do not use struct update#144

Merged
Strech merged 3 commits into
Strech:masterfrom
rockneurotiko:do_not_use_struct_update
Jul 15, 2025
Merged

Do not use struct update#144
Strech merged 3 commits into
Strech:masterfrom
rockneurotiko:do_not_use_struct_update

Conversation

@rockneurotiko
Copy link
Copy Markdown
Contributor

In Elixir 1.19, the struct update gives a warning:

warning: the struct update syntax is deprecated:

%Avrora.Schema{schema | id: id}

Instead, prefer to pattern matching on structs when the variable is first defined and use the regular map update syntax instead:

%{schema | id: id}

This PR matches the struct on the method, and then uses a normal map update.

@Strech
Copy link
Copy Markdown
Owner

Strech commented Jun 17, 2025

Hey @rockneurotiko thanks for your contribution. I think I need to update runners to succeed CI pipelines for your PR. I will do it ASAP.

Thanks ❤️

@Strech Strech merged commit fefe0a9 into Strech:master Jul 15, 2025
9 checks passed
@Strech
Copy link
Copy Markdown
Owner

Strech commented Jul 15, 2025

👋🏼 @rockneurotiko it took me a while to find time, but it's merged! Thanks a lot for keeping project up to date!

@rockneurotiko
Copy link
Copy Markdown
Contributor Author

No problem at all! Thanks for the project! 🧡

@rockneurotiko rockneurotiko deleted the do_not_use_struct_update branch July 23, 2025 12:07
@rockneurotiko
Copy link
Copy Markdown
Contributor Author

@Strech Do you expect to release a new version soon?

@Strech
Copy link
Copy Markdown
Owner

Strech commented Jul 30, 2025

Hey @rockneurotiko I will do few code changes in addition to yours and will release this week 👍🏼

@rockneurotiko
Copy link
Copy Markdown
Contributor Author

Perfect @Strech , thanks!

@Strech
Copy link
Copy Markdown
Owner

Strech commented Sep 3, 2025

Hey, I've released a fix version (decide to push it forward as my changes grow quite a bit), so it was release as 0.30.2 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants