Repository navigation
E4-4 (band 2): extract logging and SD safety into their own unit #263
Description
Epic: #212
logPrintf (54 callers), logPrintln (40), sdOpenSafe (14), logPrint (13), recordSDSuccess (12): 133 incoming edges between them, the bottom of the call stack. Nothing that calls them can move until they have.
Takes the serial ring (serialRingAppend, serialRingPeek, serialRingRead), serialLogAppend, serialLogFlush, serialLogRotate, logTimestamp, and the SD health state (sdHealth, recordSDError, trySDReInit, shouldAttemptReInit) with it. sdAvailable (fan-in 18, cut set #3) is the first cut-set variable to get an owner here.
Acceptance
- Build succeeds;
nmcomparison per B4: src/ include/ lib/ layout - behaviour-neutral #186; address shifts reported -
sdAvailableis defined in the new unit and declaredexternfrom exactly one header - Hardware verification before merge; this touches every log line the device writes
Evidence: docs/god-object-inventory.md. Regenerate the figures with python scripts/reference-graph.py --appendix.
Activity
Strycher commentedon Sep 7, 2026
🤖 Auto-promoted to Ready — all dependencies resolved (#262 closed).
refactor(#263): E4 band 2 -- logging leaves src.ino as its own unit
Strycher commentedon Sep 7, 2026
Merged in #269 (4cc1f21) under the owner's standing grant of 2026-09-07. Proof and the two calls made for review are in docs/god-object-inventory.md section 9 and the PR body.