Repository navigation
E4-5b (band 3): gps, imu, env and battery units #271
Description
Epic: #212 · Parent: #264 — band 3, second child. Created under the standing grant the owner gave on 2026-09-07; the composition is for review.
The four sensor domains, one unit each. They depend on the storage child only through fram.h (BSEC state and battery logging persist to FRAM) and settings.h (parseNMEA calls mktimeUTC).
| unit | owns | functions |
|---|---|---|
gps |
gpsData and the twelve GPS timing/debug flags (gpsBuffer, gpsBufferIndex, gpsDebugEnabled, gpsFirstFixTime, gpsFirstReceiveTime, gpsHadFirstFix, gpsHadFirstReceive, gpsLastByteTime, gpsSignalLostTime, gprmcFixThisCycle, lastRmcCycleTime, rtcSyncedFromGPS) |
initGPS, readGPS, nmeaParse, parseNMEA, getGpsAccuracyMeters |
imu |
imuData, imuAvailable, magAvailable, lis, lsm, the twelve magnetometer calibration variables |
initIMU, readIMU, loadMagCal, saveMagCal, magLogPrintln |
env |
envData, envSensor, bmeAvailable, sht4, shtData, shtAvailable, bsecState, bsecStateLoaded, bsecStateSaved, lastBsecStateSave |
initBME688, initSHT41, bsecDataCallback, readBME688, readSHT41, getIaqAccuracyText, getIaqQualityText, hPaToInHg, loadBsecState, saveBsecState, saveBsecToFRAM, loadBsecFromFRAM |
battery |
battery, batteryAvailable |
initBattery, logBatteryToSD, logBatteryToFRAM, isBatteryConnected |
Ten cut-set variables leave here: gpsData, imuData, imuAvailable, magAvailable, envData, bmeAvailable, shtData, shtAvailable, battery, batteryAvailable. The named structs from E4-1 (GPSData, IMUData, EnvData, SHTData) move into the unit headers.
Not moved: updateCompassData, updateEnvData, updateTelemetryData and the OLED draw functions consume this state; they are screens (band 4). logWeatherReading reads three of these domains and belongs to the weather child.
Acceptance
-
scripts/verify_extraction.pyPASS for the task - Both toolchains build;
pytest scripts/passes -
nmonsrc.ino.cpp.ono longer defines any variable the four units own - Record appended to
docs/god-object-inventory.md
Activity
Strycher commentedon Sep 7, 2026
🤖 Auto-promoted to Ready — all dependencies resolved (#270 closed).
refactor(#271): E4 band 3b -- gps, imu, env and battery leave src.ino…
Strycher commentedon Sep 7, 2026
Merged in #276 (e6465bb) under the owner's standing grant of 2026-09-07. Proof and the two diagnosis corrections are in docs/god-object-inventory.md section 11 and the PR body.