fix: update error summary to have position suffix for radios and check boxes and make radios and checkboxes count from 0 - #96
Open
tim-s-ccs wants to merge 1 commit into
Conversation
…kboxes and make radios and checkboxes count from 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One possible solution to this issue #92
This solution only makes updates to templates to make sure the error summary works for radios, checkboxes and conditional radios. Conditional radios have a counter in src/crispy_forms_gds/layout/containers.py that starts from 0 so in this solution I did not want to touch the python code as it would make this tricky to patch if this package never gets updated again.
Other proposed solutions:
#97
#98