ci(data): add place validator + fix gmaps_link format errors - #50
Merged
Conversation
- Add scripts/validate-places.mjs: checks all data/places/*.json for unique ids, valid type, valid coordinates (global bounds), required gmaps_link (accepts maps.google.com, maps.app.goo.gl, www.google.com/maps, goo.gl/maps), and no em dashes; exits 1 with clear per-field errors - Add `validate` npm script; wire validate-data job into ci.yml (no npm install needed - pure Node built-ins) - Fix 9 mul-book_shop entries: restore original maps.app.goo.gl short links, remove trailing spaces; restore mum-book_shop-06 to original search URL
Contributor
|
@yakew7 is attempting to deploy a commit to the anaydhawan's projects Team on Vercel. A member of the Team first needs to authorize it. |
AnayDhawan
added a commit
that referenced
this pull request
Jun 27, 2026
Bumps package.json to 1.2.0 and consolidates the CHANGELOG to the current-version-only format (drops 0.1.0 through 1.1.0 sections per standing convention). Folds in the previously undocumented yakew7 PRs: constants refactor (#46), Xiamen library addition (#48), and the place-data validator + book_shop link fixes (#50).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
validatenpm script; wire validate-data job into ci.yml (no npm install needed - pure Node built-ins)Type of change
Proof (required for new public places)
Fill this in for every place added in this PR. It stays in the PR, not in the
dataset.
gmaps_linkandadded_by(no proof fields committed).Checklist