Skip to content

ci(data): add place validator + fix gmaps_link format errors - #50

Merged
yakew7 merged 1 commit into
StudentSuite:mainfrom
yakew7:main
Jun 27, 2026
Merged

ci(data): add place validator + fix gmaps_link format errors#50
yakew7 merged 1 commit into
StudentSuite:mainfrom
yakew7:main

Conversation

@yakew7

@yakew7 yakew7 commented Jun 27, 2026

Copy link
Copy Markdown
Member

What this changes

  • Add scripts/validate-places.mjs: checks all data/places/*.json for unique ids, valid type, valid coordinates (global bounds), required gmaps_link (accepts maps.google.com, maps.app.goo.gl, www.google.com/maps, goo.gl/maps), and no em dashes; exits 1 with clear per-field errors
  • Add validate npm script; wire validate-data job into ci.yml (no npm install needed - pure Node built-ins)
  • Fix 9 mul-book_shop entries: restore original maps.app.goo.gl short links, remove trailing spaces; restore mum- Closes ci: validate data/places/*.json on PR #23

Type of change

  • New public place(s)
  • New or updated benefit guide
  • New or updated resource link
  • Code or fix
  • Docs

Proof (required for new public places)

Fill this in for every place added in this PR. It stays in the PR, not in the
dataset.

Field Value
Source or citation
Google Maps rating (must be >= 4.0)
Google Maps review count (must be >= 50)
Date verified
  • Each place's rating is 4.0 or higher.
  • Each place has 50 or more reviews.
  • Coordinates point to the correct entrance.
  • The JSON record stops at gmaps_link and added_by (no proof fields committed).

Checklist

  • The site hosts no copyrighted files; resource and paper changes are links only.
  • No em dashes in any copy.

- Add scripts/validate-places.mjs: checks all data/places/*.json for
  unique ids, valid type, valid coordinates (global bounds), required
  gmaps_link (accepts maps.google.com, maps.app.goo.gl, www.google.com/maps,
  goo.gl/maps), and no em dashes; exits 1 with clear per-field errors
- Add `validate` npm script; wire validate-data job into ci.yml (no npm
  install needed - pure Node built-ins)
- Fix 9 mul-book_shop entries: restore original maps.app.goo.gl short links,
  remove trailing spaces; restore mum-book_shop-06 to original search URL
@vercel

vercel Bot commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

@yakew7 is attempting to deploy a commit to the anaydhawan's projects Team on Vercel.

A member of the Team first needs to authorize it.

@yakew7
yakew7 merged commit 17cfecf into StudentSuite:main Jun 27, 2026
2 of 3 checks passed
AnayDhawan added a commit that referenced this pull request Jun 27, 2026
Bumps package.json to 1.2.0 and consolidates the CHANGELOG to the
current-version-only format (drops 0.1.0 through 1.1.0 sections per
standing convention). Folds in the previously undocumented yakew7 PRs:
constants refactor (#46), Xiamen library addition (#48), and the
place-data validator + book_shop link fixes (#50).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: validate data/places/*.json on PR

1 participant