Andrew/final scene audio

[anjx123]

Try turning on instakill in EP 10, running a full build. And testing the sync for the final cutscene.

TODO: Princess frog has one frame where her crown is still there.
I also need to clean up a TON of code. But tbh, this might be one of the times where I punt it till later. I have a deadline to hit.

[drew-gnaw]

OK its super gem, big props for you putting all this out in such a short time

all lgtm, only complaint is i prefer white text for the credits. Yes its not as visible in the snow, but its much MORE visible everywhere else. Or we could go with bordered text (matching the storybook text) which allows it to function on any colored background

[drew-gnaw]

Also just noticed a side effect of switching the clock to be audio-based: unity editor > project settings > timescale no longer works to fast-forward through cutscene. Doesn't really matter and audio-clock is way better but just pointing ts out

[drew-gnaw]

OK its super gem, big props for you putting all this out in such a short time

all lgtm, only complaint is i prefer white text for the credits. Yes its not as visible in the snow, but its much MORE visible everywhere else. Or we could go with bordered text (matching the storybook text) which allows it to function on any colored background

just tested this with 0.1 size black outline on white text, and i prefer it. I'll push a single commit with this change so you can test and see for yourself, feel free to revert/discuss

[anjx123]

Also just noticed a side effect of switching the clock to be audio-based: unity editor > project settings > timescale no longer works to fast-forward through cutscene. Doesn't really matter and audio-clock is way better but just pointing ts out

Yeah, as a result i had to do some scuffed ways of fast forwarding, there is a way to fast forward, it just breaks seek and thrown events.

[anjx123]

OK its super gem, big props for you putting all this out in such a short time
all lgtm, only complaint is i prefer white text for the credits. Yes its not as visible in the snow, but its much MORE visible everywhere else. Or we could go with bordered text (matching the storybook text) which allows it to function on any colored background

just tested this with 0.1 size black outline on white text, and i prefer it. I'll push a single commit with this change so you can test and see for yourself, feel free to revert/discuss

Awesome thanks for the change, let me take a look