Finish V8 15.2 runtime integration - #10
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The V8 15.2 build itself succeeded on all four targets in run 33655144716, but the generated commit could not link or pass the release tests. This fixes the remaining integration issues:
deps/so V8 15.2 headers replace the stale V8 13.6 headers instead of landing underdeps/include/include/.__config_siteand assertion handler.deps/*_*/cgo.gofiles and link every split V8 archive pluslibc++-cr.aandlibc++abi-cr.a.Verification
actionlintpython3 -m py_compile deps/build.py deps/build_common.py deps/update_cgo.pyCC=clang-21 CXX=clang++-21 go vet ./...with local dependency workspaceCC=clang-21 CXX=clang++-21 go test -a -count=1 ./...with V8 15.2 libraries and headersgit diff --checkPrevious run
All four platform builds, artifact upload, generated commit, and go.mod sync succeeded in run 33655144716. Only its release test failed because the generated link/header configuration was not committed correctly.