Validate ranking spill and maintenance fixes in Development - #402
Merged
Merged
Conversation
CountableNewt
marked this pull request as ready for review
September 13, 2026 17:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Production ranking stopped publishing during repeated Coordinator lease loss. A matched diagnostic window recorded roughly 1.77 GB of candidate-query temporary writes with only 6.16 MB of new WAL. This change reduces candidate spill and prevents maintenance work from repeatedly blocking publication.
Validation: 342 Wire tests with PostgreSQL integration, 152 OperationsCore tests serially, 11 IndexingWorker tests, and two independent-cleanup runtime tests passed. Candidate legacy-query parity covers 32 baseline/external/language/limit combinations. At 100,000 synthetic rows and unchanged 4 MB work_mem, temporary writes fell from about 479 MB to 18 MB and runtime fell about 45%; buffer lookups increased due to selected-key hydration. Production performance remains a rollout gate. Full parallel Operations tests exposed existing shared-fixture lock contention; serial execution passed.
Rollout: Development first, required CI and service/migration checks, then Production. Keep the 16 GB cap, durability, backup policy and replica counts unchanged while comparing publication freshness, actionable queue age, p95 latency, temporary writes and I/O pressure. The bundled experimental migration installs disabled triggers; verify they remain disabled. Worker/Redis aggregation work is a separate follow-up.
Refs TSW-92, TSW-114.