Fix tricoupler centre nodes disappearing sometimes.#69
Open
CensoredUsername wants to merge 1 commit intoSuicidalInsanity:masterfrom
Open
Fix tricoupler centre nodes disappearing sometimes.#69CensoredUsername wants to merge 1 commit intoSuicidalInsanity:masterfrom
CensoredUsername wants to merge 1 commit intoSuicidalInsanity:masterfrom
Conversation
Author
|
This fixes #63 |
Author
|
Note: FreeIVA has some code trying to patch this as well: https://github.com/FirstPersonKSP/FreeIva/blob/040dddc5f69ed53d4d31bbe7190dbb55fd86730b/GameData/FreeIva/Mk2Expansion/M2X_linearTricoupler.cfg#L3-L8 I'll notify them if this gets fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test case: place random object in editor. place two tricouplers in symmetry on it. Place objects on all nodes on the tricoupler. launch this device and revert to the editor. Inspecting the drag cube on the tricoupler shows very high drag on the back face, and after removing the part mounted on the centre node, no node is visible on the part.
I'm not sure why these changes fix this. I simply changed the part to use the same node naming as the stock 1 to 3 adapters, and tried to keep the numbers consistent.