Skip to content

Run the supporters workflow on Node 24, not 20 - #7

Merged
Sukarth merged 1 commit into
mainfrom
fix/supporters-node-version
Jul 29, 2026
Merged

Run the supporters workflow on Node 24, not 20#7
Sukarth merged 1 commit into
mainfrom
fix/supporters-node-version

Conversation

@Sukarth

@Sukarth Sukarth commented Jul 29, 2026

Copy link
Copy Markdown
Owner

Found by dispatching it for the first time.

@supabase/supabase-js needs Node 22+ for native WebSocket, so createClient threw before the script could query anything:

Error: Node.js detected but native WebSocket not found.
    at new SupabaseClient (...)
    at scripts/update-supporters.mjs:22:18

The workflow has never succeeded. It shipped in 1.1.0 and would have failed every Monday since, unnoticed, because nothing watches a scheduled job that has never run. db-keepalive.yml is unaffected: it pins no Node version and does not use supabase-js.

24 rather than the minimum 22, to match Vercel and local.

Summary by Sourcery

CI:

  • Change the supporters scheduled workflow Node.js version from 20 to 24 to ensure native WebSocket support for supabase-js.

supabase-js requires Node 22+ for native WebSocket, so createClient threw
before the script could query anything. The workflow has never succeeded: it
was added in 1.1.0 and would have failed every Monday since, silently, because
nobody was watching a scheduled job that had never run.

24 rather than the minimum 22, to match Vercel and local.
Copilot AI review requested due to automatic review settings July 29, 2026 13:10
@vercel

vercel Bot commented Jul 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
ib-econgraph-ai Ready Ready Preview, Comment Jul 29, 2026 1:11pm

@qodo-code-review

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@sourcery-ai

sourcery-ai Bot commented Jul 29, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates the GitHub Actions workflow for the supporters update script to run on Node 24 instead of Node 20 so that supabase-js can use native WebSocket without throwing during client creation.

Sequence diagram for the updated supporters workflow using Node 24

sequenceDiagram
    actor GitHubActions
    participant setup_node_action
    participant Node_runtime
    participant update_supporters_script
    participant Supabase

    GitHubActions->>setup_node_action: actions/setup-node@v4 node-version 24
    setup_node_action->>Node_runtime: install Node 24
    GitHubActions->>update_supporters_script: run scripts/update-supporters.mjs
    update_supporters_script->>Supabase: createClient
    alt [Node 20]
        Supabase-->>update_supporters_script: Error native WebSocket not found
    else [Node 24]
        Supabase-->>update_supporters_script: SupabaseClient created
    end
Loading

File-Level Changes

Change Details Files
Update the supporters workflow Node.js runtime to a compatible version for supabase-js and document the rationale inline.
  • Change the configured Node.js version from 20 to 24 in the supporters update workflow job.
  • Add inline comments explaining that supabase-js requires Node 22+ for native WebSocket and that 24 matches Vercel and local environments.
.github/workflows/update-supporters.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@Sukarth, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 41 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 1ddab3d6-273b-4132-89a9-657fc38589a8

📥 Commits

Reviewing files that changed from the base of the PR and between fd8c34a and 9c28be8.

📒 Files selected for processing (1)
  • .github/workflows/update-supporters.yml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Sukarth
Sukarth merged commit b1bfe24 into main Jul 29, 2026
4 of 5 checks passed

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider sourcing the Node version from a single place (e.g., an engines field in package.json or a shared workflow input) so this workflow and other environments stay in sync if you bump Node in the future.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider sourcing the Node version from a single place (e.g., an `engines` field in `package.json` or a shared workflow input) so this workflow and other environments stay in sync if you bump Node in the future.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the scheduled “Update supporters” GitHub Actions workflow to run on a newer Node.js version so the scripts/update-supporters.mjs job can successfully instantiate @supabase/supabase-js (which requires Node 22+ for native WebSocket support).

Changes:

  • Bump actions/setup-node node-version from 20 to 24 for the supporters workflow.
  • Add inline rationale comments explaining the Supabase/WebSocket requirement and why Node 24 was chosen.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants