Add final for update locks for score processing#127
Merged
richardscull merged 2 commits intoJun 14, 2026
Merged
Conversation
richardscull
deleted the
feat/add-more-for-update-locks-for-score-processing
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addition to the #126
I thought having locks on peers would be enough, but in practice it's actually not, due to having same jobs running on the same entry.
For now we are going to have lock for the score itself, which may cause the deadlocks in some scenarios, but as I said in the comment - I'm fine with it due to us having retry mechanism.
This is not the best solution just to mention and deadlocks and be completely avoidable if we are going to more all data retrieval in the transaction scope, which what we basically do with refreshes. I'll consider this as another PR later, since I want to finish interface first.
I'm also going to disable concurrency by default based on the mentioned deadlocks for the smoother experience. I would recommend to enable it if your server only needs it or you are fine with having deadlocks sometimes. Only way to have have concurrency enabled by default, is to complete the refactor as I mentioned above.