Skip to content

build(deps): update FFmpeg to 9.0.2 - #341

Merged
ReenigneArcher merged 2 commits into
masterfrom
codex/update-ffmpeg-9.0.2
Nov 15, 2026
Merged

ReenigneArcher merged 2 commits into
masterfrom
codex/update-ffmpeg-9.0.2

Conversation

@ReenigneArcher

@ReenigneArcher ReenigneArcher commented Nov 14, 2026 •

Copy link
Copy Markdown
Member

Description

Update vendored FFmpeg from 8.1.2 to n9.0.2 (946fcce07b6dcd0331c8cc609192aeff5e1924f8) and track release/9.0, preserving the nxdk build.

  • Add a reusable moonlight_patch_sources() function that stages fresh inputs, applies patches in an isolated build directory, tracks dependencies, and preserves unchanged output timestamps.
  • Use the shared helper for nxdk networking and FFmpeg's thread-wrapper adaptations. Move the thread-header replacements into a versioned patch.
  • Keep upstream's scaler source and unused jinc() helper intact. Declare j1(double) in the private nxdk compatibility header so the helper can be parsed without suppressing compiler diagnostics. The unused helper emits no j1 reference; an actual caller would still require an implementation.
  • Include the FFmpeg patch and shared helper in the rebuild signature.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Testing

Validated locally on Windows using MSYS2 MinGW64:

  • Configured with BUILD_DOCS=ON, BUILD_TESTS=ON, and BUILD_XBOX=ON; cmake --build cmake-build-release -j4 passed, including Xbox XBE/ISO packaging and the enabled video experiments.
  • ctest --test-dir cmake-build-release --output-on-failure: 285/285 passed.
  • cmake --build cmake-build-release --target docs: strict Dockle/Doxygen api build passed using the repository's existing Dockle environment, producing 438 HTML pages.
  • uv --no-cache run --locked lb-update-clang-format: passed; unrelated formatting changes were not introduced.
  • CMake lint with CI settings: 18/18 first-party files passed.
  • Incremental build passed, reused the FFmpeg libraries, and preserved timestamps for all four patched outputs.
  • llvm-nm -u verified that libswscale.a has no j1 reference. -Werror=implicit-function-declaration remains enabled, and there is no scaler source override.
  • git diff --check origin/master...HEAD: passed.

No unit tests were added: the changes affect dependency builds and a declaration-only compatibility adapter, validated through the actual Xbox configure, compile, and link steps.

Emulator and real Xbox playback were not tested. Linux/macOS builds and hosted CI are not covered by these local results.

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Tests have been added or updated for new or modified functionality, including regression tests for bug fixes

AI Usage

See our AI usage policy.

  • AI tools were used while preparing this PR

Codex assisted with implementation, review, validation, and preparing this PR description.

@codecov

codecov Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.10%. Comparing base (ff81ce0) to head (8042baf).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #341    +/-   ##
========================================
  Coverage   65.10%   65.10%            
========================================
  Files          49       49            
  Lines        5875     5875            
  Branches     2621     2621            
========================================
  Hits         3825     3825            
- Misses        969     1160   +191     
+ Partials     1081      890   -191     
Flag Coverage Δ
Linux 64.42% <ø> (ø)
macOS 52.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 15 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff81ce0...8042baf. Read the comment docs.

@sonarqubecloud

Copy link
Copy Markdown

@ReenigneArcher
ReenigneArcher merged commit ac0c971 into master Nov 15, 2026
17 checks passed
@ReenigneArcher
ReenigneArcher deleted the codex/update-ffmpeg-9.0.2 branch November 15, 2026 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant