Repository navigation
Conversation
|
ReenigneArcher
left a comment
There was a problem hiding this comment.
Requesting changes for the linked keyboard fix at the current heads (Sunshine f5f93a1, libvirtualhid 0271b64, Moonlight 3bace8b).
The new KeyboardEvent::stream_flags is never populated by keyboard_event() here. Sunshine only translates SS_KBE_FLAG_NON_NORMALIZED into uses_normalized_key_code; libvirtualhid #101 checks stream_flags & 0x02/0x04 to distinguish Korean Hangul/Hanja, so those branches are unreachable through Sunshine. The required Moonlight PR #1984 also still maps SDL_SCANCODE_LANG1/LANG2 to Japanese Henkan/Muhenkan key codes and does not emit these extra flag bits. Please coordinate the protocol/client mapping, pass the flags into the libvirtualhid event after its API update, and cover the packet-to-backend path. The current pair of PRs does not fix those keys.
Sunshine #5542 itself is currently mergeable, but this integration needs to be resolved before accepting the linked keyboard fix.
|
Hi, I would like to report a similar Japanese keyboard input issue. Environment
Problem description When using a physical Japanese JIS keyboard connected to my HarmonyOS device, the following keys do not work when streaming to my Windows PC through Moonlight and Sunshine:
Other keyboard keys work normally, and the physical keyboard itself is functioning correctly. Expected behavior These Japanese-specific keys should be correctly forwarded to the Windows host so that they can be used with Microsoft IME, just like when the keyboard is directly connected to the Windows PC. Question Does this PR also address Japanese keyboard input from Moonlight for Android clients? If not, could this issue be investigated separately? Thank you for your work! |
|
@lizebo1207336102 This PR does not address that Android-to-Windows case by itself. Its runtime change is in Sunshine's non-Windows keyboard path, and the linked client changes are for Moonlight Qt, not Moonlight Android. In current upstream Moonlight Android, the keyboard translator has no mappings for these Japanese-specific keys. For an unmapped key, the input handler only falls back to printable Unicode text, which does not forward an IME control key. Please open a separate Moonlight Android issue with your Moonlight and HarmonyOS versions, keyboard model/layout, and, if possible, the Android keycodes and scancodes generated by each affected key. That would help distinguish missing client mappings from keys intercepted by the OS. This is based on source inspection; I have not reproduced it on HarmonyOS/JIS hardware. |



Description
Fix Japanese keyboard mapping
To be fixed, Need to merge all these PRs
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage
See our AI usage policy.