Skip to content

fix(keyboard): Japanese mapping - #5542

Open
FoxRefire wants to merge 1 commit into
SunshineStream:masterfrom
FoxRefire:master
Open

FoxRefire wants to merge 1 commit into
SunshineStream:masterfrom
FoxRefire:master

Conversation

@FoxRefire

@FoxRefire FoxRefire commented Aug 22, 2026 •

Copy link
Copy Markdown

Description

Fix Japanese keyboard mapping

To be fixed, Need to merge all these PRs

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

See our AI usage policy.

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@sonarqubecloud

Copy link
Copy Markdown

@ReenigneArcher ReenigneArcher changed the title Fix Japanese keyboard mapping fix(keyboard): Japanese mapping Sep 2, 2026

@ReenigneArcher ReenigneArcher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes for the linked keyboard fix at the current heads (Sunshine f5f93a1, libvirtualhid 0271b64, Moonlight 3bace8b).

The new KeyboardEvent::stream_flags is never populated by keyboard_event() here. Sunshine only translates SS_KBE_FLAG_NON_NORMALIZED into uses_normalized_key_code; libvirtualhid #101 checks stream_flags & 0x02/0x04 to distinguish Korean Hangul/Hanja, so those branches are unreachable through Sunshine. The required Moonlight PR #1984 also still maps SDL_SCANCODE_LANG1/LANG2 to Japanese Henkan/Muhenkan key codes and does not emit these extra flag bits. Please coordinate the protocol/client mapping, pass the flags into the libvirtualhid event after its API update, and cover the packet-to-backend path. The current pair of PRs does not fix those keys.

Sunshine #5542 itself is currently mergeable, but this integration needs to be resolved before accepting the linked keyboard fix.

@lizebo1207336102

Copy link
Copy Markdown

Hi,

I would like to report a similar Japanese keyboard input issue.

Environment

  • Client OS: HarmonyOS (Android-based)
  • Client application: Moonlight for Android
  • Host OS: Windows
  • Streaming server: Sunshine
  • Keyboard layout: Japanese JIS

Problem description

When using a physical Japanese JIS keyboard connected to my HarmonyOS device, the following keys do not work when streaming to my Windows PC through Moonlight and Sunshine:

  • Henkan (変換)
  • Muhenkan (無変換)
  • Katakana (カタカナ)

Other keyboard keys work normally, and the physical keyboard itself is functioning correctly.

Expected behavior

These Japanese-specific keys should be correctly forwarded to the Windows host so that they can be used with Microsoft IME, just like when the keyboard is directly connected to the Windows PC.

Question

Does this PR also address Japanese keyboard input from Moonlight for Android clients?

If not, could this issue be investigated separately?

Thank you for your work!

Copy link
Copy Markdown
Member

@lizebo1207336102 This PR does not address that Android-to-Windows case by itself. Its runtime change is in Sunshine's non-Windows keyboard path, and the linked client changes are for Moonlight Qt, not Moonlight Android.

In current upstream Moonlight Android, the keyboard translator has no mappings for these Japanese-specific keys. For an unmapped key, the input handler only falls back to printable Unicode text, which does not forward an IME control key.

Please open a separate Moonlight Android issue with your Moonlight and HarmonyOS versions, keyboard model/layout, and, if possible, the Android keycodes and scancodes generated by each affected key. That would help distinguish missing client mappings from keys intercepted by the OS. This is based on source inspection; I have not reproduced it on HarmonyOS/JIS hardware.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Couldn't input backslash(\), pipe(|) and Muhenkan in Japanese keyboard

3 participants