Recursive is off by default for symbolic folders#206
Open
Faria22 wants to merge 1 commit intoSuperCuber:masterfrom
Open
Recursive is off by default for symbolic folders#206Faria22 wants to merge 1 commit intoSuperCuber:masterfrom
Faria22 wants to merge 1 commit intoSuperCuber:masterfrom
Conversation
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+860
to
+886
| #[test] | ||
| fn setting_recurse_true() { | ||
| let global: GlobalConfig = toml::from_str( | ||
| r#" | ||
| [settings] | ||
| recurse = true | ||
|
|
||
| [cat] | ||
| depends = [] | ||
|
|
||
| [cat.files] | ||
| cat = '~/.QuarticCat' | ||
| "#, | ||
| ) | ||
| .unwrap(); | ||
|
|
||
| let local: LocalConfig = toml::from_str( | ||
| r#" | ||
| packages = ['cat'] | ||
| "#, | ||
| ) | ||
| .unwrap(); | ||
|
|
||
| let merged_config = merge_configuration_files(global, local, None).unwrap(); | ||
|
|
||
| assert!(merged_config.recurse); | ||
| } |
There was a problem hiding this comment.
Consider adding a test case for explicitly setting recurse = false to ensure all three cases are covered: default (false), explicit true, and explicit false. This would make the test suite more comprehensive and verify that the setting works correctly in all scenarios.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this makes more sense and I believe it is the expected behavior. I also added an option in the settings to turn it on/off.