Search part globalize#1
Draft
AlistairNorman wants to merge 4 commits intomasterfrom
Draft
Conversation
AlistairNorman
force-pushed
the
search-part-globalize
branch
from
5cbc3eb to
951f08c
Compare
This had not been updated in awhile. Note the license is still Spree Commerce Inc. Co-Authored-By: Jared Norman <jared@super.gd>
I want to update this method to be able to handle translations so I want to document the original behaviour so that it is not compromised in the update.
Previously this would not find parts when searching by name with solidus globalize because it needed to search the product translations not the names themselves. This should allow this to work for both apps with and without Globalize.
AlistairNorman
force-pushed
the
search-part-globalize
branch
from
951f08c to
8ba5897
Compare
This is the direction we are going with these gems. Circle has not been working for any solidusio-contrib projects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.