Skip to content

Update to 26.1#232

Closed
Gegy wants to merge 2 commits into
SuperMartijn642:neoforge-1.21.11from
LoveTropics:neoforge-26.1
Closed

Update to 26.1#232
Gegy wants to merge 2 commits into
SuperMartijn642:neoforge-1.21.11from
LoveTropics:neoforge-26.1

Conversation

@Gegy

@Gegy Gegy commented May 2, 2026

Copy link
Copy Markdown

A first pass at a port to 26.1 - if this is something you already had plans for/had in progress, please feel free to close and ignore! 🙂

Given the larger changes in Vanilla with regards to material definitions/render layer selection, it might warrant larger breaking API changes - but generally I took the path of least resistance here. Hopefully it's a helpful starting point at least! 🙂

In particular, want to highlight:

  • Removing render_type fields from model definitions - this seems superseded by Vanilla automatically determining render layer by texture contents - likely needs updates to the wiki
  • Removing SpriteIdentifier from the API surface, and replacing with Vanilla Material - not sure the policy for breaking changes like that :)
  • Removing ConnectionPredicate resolution for generated extruded item models - it didn't seem to be an intentional feature, but could be misjudging :)

Based on #231, the bug became a lot more obvious with the updated injection point (no breaking overlay would need to be rendered for the bug to be triggered)

I've tested on a surface level with the official Fusion packs, though being not super familiar with all the features it's entirely likely that I have missed some things. :D

Gegy added 2 commits May 2, 2026 16:48
Once the breaking overlay has been rendered once, any chunk rebuild on the main thread will be considered to be part of a breaking overlay.
@SuperMartijn642

Copy link
Copy Markdown
Owner

Ah sorry, yeah I do already have 26.1 versions of Fusion. I already have and am still refactoring almost the entire mod, hence I haven't released anything yet and it will probably still be a bit.
I do appreciate your effort though, although unfortunately it likely won't be of that much use to me at this point 😅

... not sure the policy for breaking changes like that :)

Yeah between Minecraft versions breaking changes are usually unavoidable, but mods would already need to update for Minecraft's own changes anyways.
I am also sure I probably broke any mod using Fusion's API with the changes I am working on. Unfortunately, I just made parts of the mod into API when they really shouldn't have been. Since I had to make breaking changes anyways for new features in Fusion, I am taking the opportunity to just rework all of it.

Removing ConnectionPredicate resolution for generated extruded item models - it didn't seem to be an intentional feature, but could be misjudging :)

Theoretically, it would just work the same as for any other model, although, indeed, I doubt anyone is going to use an extruded item model for a block.
The model baking part was quite a mess and is what I am currently working on. Hopefully, it should be a lot nicer with all my refactors.

@Gegy

Gegy commented May 3, 2026

Copy link
Copy Markdown
Author

Ooh nice, that's great to hear! :D
Wishing you the best of luck with the refactoring - it certainly doesn't seem like an easy task. 😅

@Gegy Gegy closed this May 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants