Update to 26.1#232
Conversation
Once the breaking overlay has been rendered once, any chunk rebuild on the main thread will be considered to be part of a breaking overlay.
|
Ah sorry, yeah I do already have 26.1 versions of Fusion. I already have and am still refactoring almost the entire mod, hence I haven't released anything yet and it will probably still be a bit.
Yeah between Minecraft versions breaking changes are usually unavoidable, but mods would already need to update for Minecraft's own changes anyways.
Theoretically, it would just work the same as for any other model, although, indeed, I doubt anyone is going to use an extruded item model for a block. |
|
Ooh nice, that's great to hear! :D |
A first pass at a port to 26.1 - if this is something you already had plans for/had in progress, please feel free to close and ignore! 🙂
Given the larger changes in Vanilla with regards to material definitions/render layer selection, it might warrant larger breaking API changes - but generally I took the path of least resistance here. Hopefully it's a helpful starting point at least! 🙂
In particular, want to highlight:
render_typefields from model definitions - this seems superseded by Vanilla automatically determining render layer by texture contents - likely needs updates to the wikiSpriteIdentifierfrom the API surface, and replacing with VanillaMaterial- not sure the policy for breaking changes like that :)ConnectionPredicateresolution for generated extruded item models - it didn't seem to be an intentional feature, but could be misjudging :)Based on #231, the bug became a lot more obvious with the updated injection point (no breaking overlay would need to be rendered for the bug to be triggered)
I've tested on a surface level with the official Fusion packs, though being not super familiar with all the features it's entirely likely that I have missed some things. :D