Fix CSS and asset paths in index.html - #13
Open
daveylupes wants to merge 1 commit into
Open
daveylupes wants to merge 1 commit into
daveylupes wants to merge 1 commit into
Conversation
|
@daveylupes is attempting to deploy a commit to the Supra Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
Hi @supra-bharatjain, I noticed that the asset paths in index.html were currently broken because they included the /assist prefix despite the file already living in that directory. This fix ensures that CSS and JS load correctly for users out of the box. I've tested this locally to verify the assets now render as expected. Would appreciate a review when you have a moment! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix incorrect relative paths in index.html that prevented CSS and assets from loading correctly.
Issue:
The index.html file is located in the
assist/directory, so all asset paths should be relative to that directory, not include theassist/prefix.Testing:
Paths are now correctly relative to the assist directory where index.html is located.