feat(chrome): seed policy from portable markers - #23
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6b2ec5b395
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const genericSection = selector.includes("[data-contract-section]"); | ||
| const specificSection = | ||
| wrapper.sectionId && | ||
| (selector.includes(`[data-contract-section="${wrapper.sectionId}"]`) || |
There was a problem hiding this comment.
Ignore descendant selectors in chrome wrapper matching
This branch marks a section wrapper as matched whenever a selector string contains data-contract-section, but it never checks whether the selector actually targets the wrapper itself versus descendants. As a result, rules like [data-contract-section] > * { border-radius: 12px; } are incorrectly attributed to the section marker, inflating extracted chrome signals and seeding layout.chromePolicy with values that are not applied to governed wrappers.
Useful? React with 👍 / 👎.
Summary
Testing