Skip to content

feat(chrome): seed policy from portable markers - #23

Merged
mikeylong merged 2 commits into
mainfrom
codex/portable-chrome-opt-in
Mar 10, 2026
Merged

mikeylong merged 2 commits into
mainfrom
codex/portable-chrome-opt-in

Conversation

@mikeylong

Copy link
Copy Markdown
Collaborator

Summary

  • extract deterministic chrome observations from portable markers instead of defaulting every web surface
  • treat .contract-container as the primary layout-container signal, keep page-container optional, and preserve legacy data-contract-container compatibility
  • seed chromePolicy conservatively from observed descriptors and document the portable opt-in adoption path

Testing

  • pnpm --filter @surfaces/interfacectl-cli run build
  • pnpm --filter @surfaces/interfacectl-cli test

@vercel

vercel Bot commented Mar 10, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
interfacectl Ready Ready Preview, Comment Mar 10, 2026 7:19pm

Request Review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6b2ec5b395

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +1037 to +1040
const genericSection = selector.includes("[data-contract-section]");
const specificSection =
wrapper.sectionId &&
(selector.includes(`[data-contract-section="${wrapper.sectionId}"]`) ||

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Ignore descendant selectors in chrome wrapper matching

This branch marks a section wrapper as matched whenever a selector string contains data-contract-section, but it never checks whether the selector actually targets the wrapper itself versus descendants. As a result, rules like [data-contract-section] > * { border-radius: 12px; } are incorrectly attributed to the section marker, inflating extracted chrome signals and seeding layout.chromePolicy with values that are not applied to governed wrappers.

Useful? React with 👍 / 👎.

@mikeylong
mikeylong merged commit bd172f4 into main Mar 10, 2026
4 checks passed
@mikeylong
mikeylong deleted the codex/portable-chrome-opt-in branch March 19, 2026 00:48

This branch had an error being deployed

1 failed (outdated) and 1 active deployments
Preview — b12fae9d Deployed Mar 10, 2026 by vercel[bot]
Production — 6b2ec5b3 Deployed Mar 10, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant