feat(cli): improve first-run web onboarding - #26
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cfaf58d491
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| input.renderedGateObservation.hasPasswordField || | ||
| hasLoginForm || | ||
| loginHeadingDetected || | ||
| ((loginMainDetected || loginBodyDetected) && urlLooksLikeLogin); |
There was a problem hiding this comment.
Detect login pages without requiring login-like URL paths
In detectAuthGate, login text from the rendered page is only treated as a login signal when urlLooksLikeLogin is true, which means common OAuth/SSO gates on paths like /oauth2/* or /auth/* can be classified as sourceHealth.status = "ok" if they do not expose a password field or login form text. init and analyze rely on this status for gated-source handling, so these flows can silently proceed as if the target surface was accessible and generate non-provisional artifacts from a gate page.
Useful? React with 👍 / 👎.
Summary
interfacectllaunch a terminal onboarding flow for interactive first runsinitpreview/success output to be plain-language by default with--verbosefor technical detailTesting