feat(validator): add authoring contract metadata - #28
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 180443b0d4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
|
|
||
| for (const slotBehavior of rule.slotBehaviors ?? []) { | ||
| if (knownSlotIds.size > 0 && !knownSlotIds.has(slotBehavior.slotId)) { |
There was a problem hiding this comment.
Validate slotBehaviors even when no section slots are known
The knownSlotIds.size > 0 guard means sections[*].responsive.rules[*].slotBehaviors[*].slotId is never validated when a section omits anatomy.slots and has no resolvable defaultComponent, so contracts with completely unknown slot references are accepted as structurally valid. This undermines the new referential-integrity guarantees for responsive metadata and can surface later as generator/runtime failures when a slot behavior targets a slot that does not exist.
Useful? React with 👍 / 👎.
Summary
Testing