Skip to content

feat: add guided generation benchmark tooling - #32

Merged
mikeylong merged 7 commits into
mainfrom
codex/interfacectl-generation-benchmark-loop
Mar 13, 2026
Merged

mikeylong merged 7 commits into
mainfrom
codex/interfacectl-generation-benchmark-loop

Conversation

@mikeylong

Copy link
Copy Markdown
Collaborator

Summary

  • add canonical guided-vs-unguided generation benchmark tooling to interfacectl
  • support reviewed warn outcomes, session comparisons, contract-delta suggestions, and benchmark reports
  • add schemas, tests, and docs for the benchmark loop

Testing

  • pnpm --filter @surfaces/interfacectl-cli run build
  • pnpm --filter @surfaces/interfacectl-cli exec node --test test/generation-session.test.mjs test/generation-benchmark.test.mjs
  • pnpm --filter @surfaces/interfacectl-cli run test

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8aff2b967e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +742 to +745
if (parsedFindings.length > 0) {
findings.push(...parsedFindings);
evaluation = parseGuardEvaluation(payload);
} else {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Parse guard evaluation even when findings are empty

When the generation guard returns JSON with no findings (the common pass path), this branch skips parseGuardEvaluation(payload) and leaves evaluation at its default values, so adapter responses can incorrectly report colorPolicyEvaluated=false / iconPolicyEvaluated=false in descriptor-parity runs. tools/check-generation-boundaries.mjs emits an evaluation object even on zero-findings responses, so this loses real coverage data and can skew benchmark/report gating that relies on coverage fields.

Useful? React with 👍 / 👎.

Comment on lines +1271 to +1272
case "restrict-icon-sources":
return "icons.allowedSources";

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Point icon-source suggestions at surface-scoped contract path

This maps restrict-icon-sources to icons.allowedSources, but icon policy is defined per surface (surfaces[].icons). As a result, generated contract-delta suggestions for icon.source-disallowed direct reviewers to a non-existent/wrong contract path, which makes accepted suggestions hard to apply correctly and can cause edits in the wrong place.

Useful? React with 👍 / 👎.

Comment on lines +1267 to +1268
case "restore-marketing-typography-profile":
return `surfaces[id=${surfaceId}].allowedFonts`;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Map typography-profile repair to typography profile fields

restore-marketing-typography-profile currently resolves to surfaces[id=...].allowedFonts, but the underlying repair and finding are about marketingTypographyProfile/policy, not the font allowlist. This produces misleading suggestion paths for marketing.typography.profile-missing, so reviewers are directed to edit unrelated fields instead of the actual contract knobs that control the violation.

Useful? React with 👍 / 👎.

@mikeylong
mikeylong merged commit 821a63d into main Mar 13, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant