Repository navigation
chore(ci): skip tarball portability test when workspace deps are unpublished - #9
Merged
Merged
Conversation
…blished - Preflight: collect @surfaces/* deps from CLI package.json, run npm view <pkg> version - If any @surfaces/* dep is not on npm, skip test with explicit SKIP message - Add timeout (5s) for npm view; add comment describing skip behavior - Keeps test meaningful when all deps are published Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why it failed
CI failed because the tarball portability test installs the packed CLI in a clean temp project via
npm install <tarballs>. The CLI depends on@surfaces/interfacectl-extractor(and@surfaces/interfacectl-validator), which are not published to npm yet, sonpm installreturns 404.Skip condition
Before running the install, we collect all
@surfaces/*dependencies from the CLI package.json and runnpm view <pkg> version --jsonfor each. If any of these commands exits non-zero (e.g. 404), we skip the test and print:SKIP tarball portability: unpublished dependency <list>Behavior
@surfaces/*deps are published, the test runs unchanged and still validates installability.Follow-up
Remove the skip once
@surfaces/interfacectl-extractor(and any other workspace-only deps) is published to npm, or the CLI no longer depends on it at runtime.Made with Cursor