feat(inference): add tool schema translation layer - #100
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #78
Description
Translate MCP tool inventories (
ToolInfo.input_schema) into OpenAI-compatible function tool definitions carried onCompletionRequest.tools, withmcp__<server>__<tool>dedupe and a reverse-routing map. Request-side only: response-side tool-call parsing lands with the agent loop.Implementation
ToolDefinitionmodel +CompletionRequest.toolsfield in the inference vocabularyOpenAIAdapter._chat_kwargswraps definitions into the{"type": "function", ...}wire envelope (absent when none/empty)octave.toolspackage:translate_tools()convertsServerToolInventoryfleets intoProviderToolset(defs + routes), sanitizing/truncating exposed names to the OpenAI charset (^[a-zA-Z0-9_-]{1,64}$) and raisingToolNameCollisionErroron collisions$schema, deep-copied so inputs are never mutatedoctave.mcpnoroctave.inferenceimports the other; SDK quarantine guarded by an AST hygiene testReferences
.agents/specs/2026-09-22-tool-schema-translation-design.md.agents/specs/2026-09-22-tool-schema-translation.mdChecklist