This repository was archived by the owner on Oct 10, 2025. It is now read-only.
chore: echarts type and add settings property#28
Merged
SAKURA-CAT merged 3 commits intomainfrom May 15, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
A maintenance PR updating versioning, adding new features to the LazySettings class, and extending chart types and unit tests.
- Updated pyproject.toml version to 0.1.8.
- Added a new ECHARTS ChartItem in swankit/core/data.py.
- Enhanced LazySettings by introducing optional type hints and an immutable tags property, with new related unit tests.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/unit/core/test_settings.py | Added unit tests for LazySettings immutability behavior using try-except for exception checking. |
| swankit/core/settings.py | Updated type hints for LazySettings and added a new immutable tags property. |
| swankit/core/data.py | Introduced a new chart type ECHARTS to the ChartItem enum. |
| pyproject.toml | Updated version from 0.1.7 to 0.1.8 to reflect the latest changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to the
swankitlibrary, focusing on versioning, feature additions, and enhancements to theLazySettingsclass. It also introduces a new unit test for theLazySettingsclass. Below are the key changes grouped by theme:Versioning Update:
pyproject.tomlfrom0.1.7to0.1.8to reflect new changes.Feature Additions:
ECHARTS, to theChartItemenumeration inswankit/core/data.py.tagsproperty in theLazySettingsclass, allowing optional tagging with a setter that enforces immutability after the first assignment. [1] [2]Enhancements to
LazySettings:LazySettings(exp_colors,description) to make them optional, improving flexibility. [1] [2]Unit Testing:
test_lazy_settings, intest/unit/core/test_settings.pyto validate the behavior of theLazySettingsclass, including immutability checks for properties.