Skip to content

Comments

Feature/open api#1414

Merged
Zeyi-Lin merged 21 commits intomainfrom
feature/open-api
Feb 3, 2026
Merged

Feature/open api#1414
Zeyi-Lin merged 21 commits intomainfrom
feature/open-api

Conversation

@SAKURA-CAT
Copy link
Member

Description

全新的OpenAPI类型

Closes: #1369

Bainianzzz and others added 4 commits January 4, 2026 11:28
* feat: get all project of a group

* update unit test using magicMock

* update unit test & fix bug

* opt import and rename some file

- move api from folder core_python to api

* fix wrong comment

* remove pending status when getting entity projects

* opt Project class

- add EN comment for Project properties
- add __str__ method for project label
- adapt snake_case naming for project properties
- change some project property name: projectLabels -> label
- change api.projects() param name: entity -> workspace
- delete some project properties (group, cuid)
- prase url inside Project class

* dynamically request project data according to the traversal of the project, rather than requesting all project information at once

* opt import

* iteratively request project data inside the Projects class

- move api form api package to core_python package

* fix bug & add type

* move api's type.py to core_python
* feat: get runs metadata

- add api in core_python to get all exps in a project
- add new type and class to parse exps

* update unit test & fix bugs

* opt code style & add comment

* raise value error if user's path is invaded

* fix bug of Incorrectly raised ValueError

* get single exp through OpenApi

* resolve conflicts: filtering exp (basic implement)

- get full single exp info through filter func

# Conflicts:
#	swanlab/core_python/api/experiment.py

* opt __dict__ for project and experiment

* resolve conflict: update run.history()

* feat: update run.scan_history()

- add example codes

* resolve conflict: fix bugs when importing pandas

* import pandas only when used

* fix: pandas warning

* feat: run and user features of OpenApi

- get metric data in batch
- recover old OpenApi version for smooth transition
- create & delete api_key through Api.user

* opt Client importing in core_python's api

* opt logic of run.history()

- get latest api_keys when user delete api_key

* rename the deprecated openApi folder

* refactored run.history() & add return type

- add return type for the backend interfaces
- simplified get_experiment_metrics() and handle the csv inside HistoryPool

* removed redundant types

* update unit test using mock

* feat: get user's team

* feat: create user if user is the root user in self-hosted swanlab

- refactor the models in OpenApi

* feat: update unit test for create user and get user teams

* delete test code of OpenApi

* use ThreadPoolExecutor in HistoryPool

* Refactor Api class and cleanup api module structure

Moved the Api class implementation from swanlab/api/api.py to swanlab/api/__init__.py and deleted the redundant api.py file. Updated imports and references accordingly. Minor docstring and comment improvements, and fixed a message in thread.py to reference 'Api' instead of 'OpenApi'.

* Fix circular import by updating Api export

Combined the import of OpenApi and Api from .api to prevent circular import issues and simplify the export process.

---------

Co-authored-by: ZeYi Lin <944270057@qq.com>
Co-authored-by: Kang Li <cunykang@gmail.com>
* Refactor the OpenAPI codes, managing the code with a modular approach

* combine 3 kinds of user into one

- use @cached_property to cache some property of user

* Place the API's custom type into a separate module

- place class ApiBase into a single model

* get the user identity at the init of the OpenApi

- only the root user get by api.user() can create new account

* refactor module name & structure in api and core_python

* Modified parameter passing convention & add client property to ApiBase

- pass param through kwargs except client in OpenApi and core_python

* update code commit

- opt str() of Label class
@SAKURA-CAT SAKURA-CAT requested a review from Zeyi-Lin January 13, 2026 03:47
@SAKURA-CAT SAKURA-CAT added 💪 enhancement New feature or request 🔌 api SwanLab OpenAPI labels Jan 13, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @SAKURA-CAT, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

此拉取请求对 SwanLab 的 OpenAPI 接口进行了全面重构和升级。核心目标是提供一个更现代化、面向对象且易于使用的编程接口,以便用户能够更高效地通过代码与 SwanLab 平台进行交互。通过引入新的 Api 入口类和一系列专用对象(如 ExperimentProjectUser),此次更新显著提升了API的结构清晰度、可扩展性和用户体验,同时将旧版API标记为废弃以引导用户过渡到新接口。

Highlights

  • 全新的OpenAPI接口: 引入了全新的 Api 类作为 SwanLab OpenAPI 的主要入口,取代了旧的 OpenApi 类,提供了更直观、面向对象的操作方式。
  • 旧版API迁移与废弃: 原有的 OpenApi 类及其相关模块已迁移至 swanlab/api/deprecated/ 目录,并标记为即将废弃,同时在旧版 OpenApi 类的构造函数中添加了废弃警告。
  • 模块化API设计: 新增了 ExperimentExperimentsProjectProjectsUser 等专用类,用于封装实验、项目和用户相关的操作,使API结构更加清晰和易于管理。
  • 核心API功能重构: 后端API函数已重构并移动到 swanlab/core_python/api/ 目录下,并引入了新的类型定义,提高了代码的组织性和可维护性。
  • 并发指标数据获取: 新增 HistoryPool 类,支持并发获取实验指标数据,提高了数据检索效率。

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

本次 PR 对 OpenAPI 模块进行了一次重大的、结构清晰的重构。新的 swanlab.Api 类提供了更现代化、面向对象的接口,同时旧的 OpenApi 也被妥善地标记为弃用。代码被组织到清晰的项目、实验和用户模块中,极大地提高了可维护性。我发现了一些关键问题,尤其是在迭代器逻辑和错误处理方面,以及一些可以提高效率和代码风格的地方。此外,为新的 API 添加单元测试将是确保其正确性和稳定性的重要一步。

Bainianzzz and others added 4 commits January 19, 2026 13:06
* add unit test

- add unit test and fix bugs of getting all projects through OpenApi
- add unit tests for OpenApi runs and run.history()

* add unit test for api.user()

* accept suggestions from gemini
* delete class ApiBase

* accept suggestions

- place yield inside the loop of the projects
- check if creating & deleting user or api_keys inside the api func
- add property is_self in user

* opt user api func

* fix bugs in projects

* accept gemini suggestions

- fix type error in self_hosted.py and user's api func
- add a constant for project page size

* opt over-encapsulated code

- discard constant PAGE_SIZE
- let adapter handle the exception when creating & deleting user info
- opt unit test for projects

* delete unused utils
Bainianzzz and others added 13 commits January 21, 2026 11:34
…1425)

* use a wrapper to check self_hosted info for some functions

- update unit tests for user (add self_hosted context)

* fix bug in OpenApi.list_workspaces()

* accept gemini suggestions

* raise value error when not being self_hosted

* raise value error when self_hosted is not available

- raise error when accessing unsupported user functions
…ace object (#1430)

* Replace the workspace field in the project object with a workspace object

* cached the workspace object
* fix bugs when getting exp info when profile is None

- use getattr() to get profile and related info

* accept gemini suggestions
* get all user when login as root user

- opt @self_hosted decorator identity checking
- add api func get_users()

* accept gemini suggestions

* move get all users function from user to api

- opt identity checking logic

* Refactor user listing to use Users iterator class

Replaced the users() method in Api to return a new Users iterator class instead of yielding User objects directly. Added swanlab/api/users/__init__.py to encapsulate user iteration logic, improving code organization and separation of concerns.

* Add user pagination test and utility function

Added a test for paginated user retrieval in test_user.py and implemented create_user_data in utils.py to simulate paginated user data. Also clarified the docstring in create_user for self-hosted admin restriction.

---------

Co-authored-by: Kang Li <cunykang@gmail.com>
* get single project through openApi

- add api func get_project_info

* accept gemini suggestions

* Refactor workspace and project param names to 'path'

Replaces 'workspace' parameters with 'path' across API, core_python, and test modules for consistency. Updates related function calls, class initializations, and docstrings to reflect the new naming convention.

* Refactor Workspace initialization and usage

Updated Workspace class to require client and data parameters, removing path-based initialization logic. Refactored related API, Project, and Workspaces classes to fetch workspace data before instantiating Workspace, ensuring consistent and explicit data handling.

---------

Co-authored-by: Kang Li <cunykang@gmail.com>
Remove the threaded HistoryPool helper and simplify Experiment.history by fetching per-key CSVs inline. Deleted swanlab/api/experiment/thread.py and removed its import. The history method now normalizes keys (allowing a single string), appends x_axis, deduplicates, retrieves CSV URLs via the client, reads them with pandas, strips a common prefix and trailing "_step" from column names, and concatenates DataFrames (inner join when x_axis is present, outer otherwise). When x_axis is given, timestamp columns are dropped, the x_axis column is validated and moved to the front. The method now raises if keys is None and supports sample trimming. Note: concurrency via HistoryPool is removed and the pandas parameter is effectively unused (the method returns a pandas DataFrame).
Remove Experiment.config and Experiment.summary properties and rename the Experiment.history(...) method to Experiment.metrics(...). Update docstrings, example usage and the pandas import error message to reference metrics. This is an API change — update callers to use exp.metrics(...) and note that config/summary accessors were removed.
Introduce x_axis_state to centralize x_axis checks and only append x_axis to keys when applicable. Replace pd.concat(join_type) with iterative outer .join(...).sort_index() to build the result DataFrame, and keep timestamp columns dropped as before. After reordering columns to put x_axis first, filter out rows where x_axis is NaN. Minor cleanup and readability improvements.
Refactor Experiment.metrics: tighten keys validation (keys must be a non-empty list of strings), simplify docstring and pandas import error message, and treat pandas param as reserved. Normalize x_axis handling (default 'step'), append x_axis when needed, and fetch each metric CSV. Extract common prefix from the first column, strip that prefix and the "_step" suffix in a Python 3.8-compatible way, then outer-join and sort the DataFrames. When x_axis is used, drop timestamp columns, ensure x_axis exists, move it to the first column and drop rows with null x_axis. Finally apply the optional sample limit.
@Zeyi-Lin
Copy link
Member

Zeyi-Lin commented Feb 3, 2026

做一些改进:

  1. history更名为metrics,更接近功能本身的含义
  2. 当keys为None时,不再全量返回指标
  3. 删掉config和summary,等后续更新
  4. 重构部分代码,优化了多个key下的数据合并逻辑

@Zeyi-Lin Zeyi-Lin merged commit 23b8790 into main Feb 3, 2026
5 checks passed
@SAKURA-CAT SAKURA-CAT deleted the feature/open-api branch February 11, 2026 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🔌 api SwanLab OpenAPI 💪 enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OpenApi V2

3 participants