Repository navigation
LOCAL: tell Codex and Tenki to review only the fork's lines on an upstream sync PR - #26
Conversation
…tream sync PR Both reviewers read review rules from AGENTS.md, and neither offers a per-branch or per-label skip. A sync PR's diff is almost all upstream code that the fork leaves unchanged, so most of their findings on it cannot be acted on here. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Review complete. No issues found — approved ✅. Documentation-only change to Reviewed commit: 0ac49cb |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0ac49cb6d0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…or review A reviewer could read "merge base with main" against the integration branch. Name the second parent, and say which main is meant. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fac8094914
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Review complete. No issues found — approved ✅. Adds a SwapLabs fork section to Reviewed commit: fac8094 |
Superseded by a newer Tenki approval on this pull request.
ELI5
The daily sync PR pulls hundreds of upstream commits into the fork at once. Codex and Tenki review every line of it and leave findings on upstream's code, which the fork deliberately doesn't change. This adds a rule to
AGENTS.md, which both reviewers read: on a sync PR, review only the fork's own lines and its conflict resolutions.What Changed
Before: on sync: upstream 31012aeb09 into swaplabs/main #22, all 3 open Codex findings were on upstream lines, which the fork can't act on (
release-policy.yml,release-policy.mjs,github-release-update-source.ts, all unchanged from upstream31012aeb09).After:
AGENTS.mdgains a# SwapLabs Fork→## Code Review Rulessection. Codex looks for that heading, and Tenki applies the whole file. The rule covers PRs intoswaplabs/mainwhose head ismainorsync/upstream-*. On those, it asks for review of only:git show --remerge-diff).Every other PR is reviewed as before.
The section sits between two upstream sections, not at the end of the file, to keep sync conflicts unlikely. Upstream has edited
AGENTS.md3 times in its recent history.Why
AGENTS.mdis the only lever either reviewer offers that lives in the repo.sync/upstream-*heads, because amainhead carries upstream'sAGENTS.md. Every thread on amain-headed PR is upstream-owned anyway. The hard rule is in theorca-fork-opsauto-sync procedure (SwapLabsInc/SwapLabs#137): the automation classifies each thread by owner, fixes the fork's, and logs upstream's for the operator.Linked Issue
None. Fork-only; follows #22 and SwapLabsInc/SwapLabs#137.
Visual Proof
N/A. Reviewer instructions only; no app change.
Testing
This is documentation only, so there is nothing to unit-test. The real test is the next sync PR on a
sync/upstream-*head: fewer findings on upstream lines.AI Disclosure
Written by Claude Opus 5.5 (Claude Code).
Agent skill upstream boundary
docs/reference/agent-skill-sharing-upstream-boundary.mdand copies or mechanically translates no upstream skill-installer source, tests, fixtures, registry entries, path tables, comments, or documentation.Checklist
N/Awith reasonpnpm lint,pnpm typecheck,pnpm test, andpnpm buildpass (or CI will cover; local preferred)Deferred follow-ups
main-headed sync PR: its merge base withmainis the head itself, so it has no fork lines to review. The current wording already implies this.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.