Repository navigation
LOCAL: build each macOS slice on its own architecture's runner - #46
Merged
Merged
Conversation
Since upstream stablyai#27021, packaging boots each slice's signed terminal host and requires a PTY within 20 s. The fork packaged both slices on one hosted arm64 runner, where the x64 host runs under Rosetta and missed that window on both attempts of build 23 (run 39820225306), so 23cb211's release shipped without macOS assets. Upstream packages on faster Blacksmith runners. build-mac is now a matrix: x64 on macos-15-intel, arm64 on macos-15. Each leg packages, zips, signs, uploads and verifies only its own slice. A leg whose manifest fails verification removes only that slice's manifest, so one bad leg no longer takes the other's verified update away. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
Since the 22 October sync, the fork's macOS build fails before it can publish. Release
…202610221710(build of23cb211af5) went live with Linux assets only, so Mac users get no update from it. This PR moves each macOS architecture onto a GitHub runner of that architecture, so the failing check runs natively.What Changed
build-macin.github/workflows/swaplabs-build.ymlis now a two-leg matrix:macos-15-intel;macos-15.Each leg packages, zips, signs, uploads and verifies only its own slice.
When a leg's update manifest fails verification, it removes only that slice's manifest and signature. Before, a failure removed both slices' manifests; a single job made that the same thing. Now one bad leg no longer takes away the other slice's verified update.
Why
Upstream stablyai#27021 (in the fork since #38) added a packaging check. After signing, it boots each slice's terminal-host helper and requires a working terminal within 20 s.
The fork packaged both slices on one arm64 runner, so the x64 helper ran under Rosetta. In build 23 it timed out at the 20 s mark on both attempts ("did not serve a PTY: no daemon token"). Upstream runs the same check on faster Blacksmith macOS runners.
Alternatives considered:
The fork's own CI already runs on
macos-15-intel(for examplepersistence (macos-15-intel)on #38).Linked Issue
N/A. Found on build 23 after #38. Related: #39, the missing orcad template, which this doesn't change.
Visual Proof
N/A: CI only.
Testing
config/scripts/swaplabs-build-workflow.test.mjsandswaplabs-build-workflow-mac-signing.test.mjsare updated:Results:
swaplabs-*config tests and the workflow-scanning contract tests: 10 files, 252 passed, 1 skipped.oxfmtandoxlintare clean.The workflow itself runs only on a push to
swaplabs/main, so the real proof is the build that this merge triggers.AI Disclosure
Prepared with Claude Code (Claude Opus 5.5).
Agent skill upstream boundary
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.