feat(sb): the end & armors - #860
Draft
ArikSquad wants to merge 8 commits into
Draft
Conversation
- also uses Component#translatable on Material
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
ArikSquad
marked this pull request as draft
August 8, 2026 20:00
ArikSquad
marked this pull request as ready for review
August 9, 2026 12:16
ArikSquad
changed the base branch from
feat/add-skyblock-armor-sets-on-config
to
master
August 9, 2026 12:16
ArikSquad
changed the title
# Conflicts: # commons/src/generated/java/net/swofty/commons/skyblock/item/ItemType.java
ArikSquad
changed the title
ArikSquad
marked this pull request as draft
August 9, 2026 12:34
ArikSquad
commented
Aug 9, 2026
| import java.util.Map; | ||
| import java.util.regex.Pattern; | ||
|
|
||
| public final class ConfiguredArmorSet implements ArmorSet { |
Swofty-Developments
requested changes
Aug 9, 2026
Swofty-Developments
left a comment
Swofty-Developments
left a comment
Owner
There was a problem hiding this comment.
I know this is still WIP just thought I'd add a note to the EndProgress class
|
|
||
| import java.util.List; | ||
|
|
||
| public final class EndProgress { |
There was a problem hiding this comment.
If every method requires a player this should be a record taking in a SkyBlockPlayer
Collaborator
Author
There was a problem hiding this comment.
endprogress will probably be changed into just the mission system, this is kind of a sloppy way to do this
|
|
||
| import java.util.function.Function; | ||
|
|
||
| public abstract class EndNpc extends HypixelNPC { |
Collaborator
Author
There was a problem hiding this comment.
a human could never write this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reference data: SkyBlock Armor wiki and the official SkyBlock items API.