Skip to content

Update dependencies and fix bot-mail suppression under Flask-Security 5.9 - #333

Merged
mreid-tt merged 2 commits into
SynoCommunity:mainfrom
mreid-tt:chore/update-dependencies
Oct 14, 2026
Merged

mreid-tt merged 2 commits into
SynoCommunity:mainfrom
mreid-tt:chore/update-dependencies

Conversation

@mreid-tt

Copy link
Copy Markdown
Contributor

Summary

Refresh the dependency lock (33 packages) and fix the one behavioural regression the upgrade surfaced.

Dependency update (uv lock --upgrade)

Notable direct bumps:

  • SQLAlchemy 2.0 → 2.1
  • Flask-Security 5.8 → 5.9
  • Flask-Admin 2.2.0 → 2.2.1
  • Celery → 5.6
  • python-gnupg, boto3, and ~28 transitive packages

Fix: bot-mail suppression (spkrepo/mail.py)

Flask-Security 5.9 changed how the "existing email/username" registration mails are addressed: they were hardcoded bare names ("welcome_existing"), now they come from config as full paths ("security/email/welcome_existing"). Our suppression set holds bare names, so it stopped matching and the bot-triggered mails would have been sent again.

SpkrepoMailUtil.send_mail now matches on the template's base name (template.rsplit("/", 1)[-1]), so the suppression holds regardless of where Flask-Security keeps its templates.

Verification

  • pytest — 380 passed, 45 subtests.
  • sphinx-build -W -b html clean (pydata-sphinx-theme / docutils also bumped).
  • pre-commit clean.

@mreid-tt mreid-tt self-assigned this Oct 14, 2026
@mreid-tt mreid-tt added dependencies Pull requests that update a dependency file python Pull requests that update python code labels Oct 14, 2026
@mreid-tt
mreid-tt merged commit 5e20581 into SynoCommunity:main Oct 14, 2026
2 checks passed
@mreid-tt
mreid-tt deleted the chore/update-dependencies branch October 14, 2026 08:45
@mreid-tt mreid-tt mentioned this pull request Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file python Pull requests that update python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant