Repository navigation
Update dependencies and fix bot-mail suppression under Flask-Security 5.9 - #333
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refresh the dependency lock (33 packages) and fix the one behavioural regression the upgrade surfaced.
Dependency update (
uv lock --upgrade)Notable direct bumps:
Fix: bot-mail suppression (
spkrepo/mail.py)Flask-Security 5.9 changed how the "existing email/username" registration mails are addressed: they were hardcoded bare names (
"welcome_existing"), now they come from config as full paths ("security/email/welcome_existing"). Our suppression set holds bare names, so it stopped matching and the bot-triggered mails would have been sent again.SpkrepoMailUtil.send_mailnow matches on the template's base name (template.rsplit("/", 1)[-1]), so the suppression holds regardless of where Flask-Security keeps its templates.Verification
pytest— 380 passed, 45 subtests.sphinx-build -W -b htmlclean (pydata-sphinx-theme / docutils also bumped).pre-commitclean.