Replace usize column index with a generic #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ToxicMushroom
commented
Dec 24, 2025
Collaborator
|
Looking good so far 👍🏼 |
Author
|
Is the example + small docs-tests is enough testing material ? |
maccesch
requested changes
Dec 29, 2025
Collaborator
maccesch
left a comment
maccesch
left a comment
There was a problem hiding this comment.
Testing and docs are very well taken care of, thank you!
| // Event handler callback when this row is selected | ||
| on_select: EventHandler<web_sys::MouseEvent>, | ||
| // Phantom data needs the column index type (a generated enum in this example) | ||
| _phantom: PhantomData<BookColumn> |
Collaborator
There was a problem hiding this comment.
Since the component isn't generic, this shouldn't be necessary.
I think instead of adding the PhantomData to the renderer function's signature we should add it as a field to the generated struct in the macro renderer_fn!.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lays groundwork for adding features like column hiding and column ordering as envisioned in #58 via a generated enum.
Enum generation and switching between current usize and the enum is handled in Synphonyte/leptos-struct-table-macro#13.
This currently serves as a progress tracker and place to give preliminary feedback.