Repository navigation
Add confirmed local FFmpeg audio preparation workflow - #1
Closed
LittleLaXerath wants to merge 1 commit into
Closed
LittleLaXerath wants to merge 1 commit into
LittleLaXerath wants to merge 1 commit into
Conversation
Add a first-class Audio Preparation page for local file selection or drag-and-drop, media probing, PCM WAV preparation, EBU R128 analysis, confirmed loudness normalization, before/after playback, file-location handoff, path copying, and Save As. Every write-capable action shows its input, parameters, and destination, creates a unique output, and preserves the source file. Replace the component placeholder with an operational FFmpeg maintenance surface. Add typed C ABI DTOs and bindings, SafeHandle job ownership, process-wide mutual exclusion, progress polling, race-safe cancellation, a cross-page global job bar, cached task pages, and shutdown cleanup. Correct x64/ARM64 Rust target mapping and expand the non-GUI ABI smoke test across component status and all four allow-listed FFmpeg operations. Update the pi-agent submodule to 5cdb12f, where the conversational Agent exposes only read-only probe and loudness analysis tools. Keep preparation and normalization behind Desktop confirmation. The existing pi-agent to synthv-agent-bridge to SynthV live note-insertion path remains unchanged. 中文:新增独立的音频准备页面,支持选择或拖入文件、格式检测、PCM WAV 准备、EBU R128 响度测量、确认后标准化、前后试听、打开位置、复制路径与另存为。所有写入操作都会展示输入、参数和输出位置,只生成唯一命名的新文件,不覆盖源音频,也不自动导入 SynthV 或运行 CVRS。 中文:加入真实 FFmpeg 组件维护界面、类型化 C ABI、SafeHandle、全局单任务互斥、进度与安全取消、跨页面任务条、页面状态保留和关闭清理;修正 x64/ARM64 native 构建映射并扩展真实 ABI 冒烟测试。同步 pi-agent 只读权限提交,同时保持 SynthV 实时音符插入链路不变。完整中英文更新记录见 CHANGELOG.md。 Validation: real C ABI smoke passed probe, prepare, loudness analysis, and normalization; Rust passed 57 tests with 2 intentionally ignored and Clippy -D warnings; SynthV Bridge passed 240 checks and remained unchanged; XAML XML and event-handler checks passed. Full WinUI XAML and ARM64 native builds remain pending on a node with Visual Studio C++ Build Tools, MSVC linker, and Windows SDK.
Contributor
Author
|
Superseded by the native Tauri implementation in #2 and #3. The original branch is intentionally preserved as a UX and test reference, but it is based on the removed WinUI/P/Invoke architecture and cannot be safely rebased onto the current Rust/Tauri mainline. The replacement keeps the confirmed-write, PCM preparation, EBU R128, progress/cancellation, preview, safe Save As, and path-safety advantages while staying close to the current codebase. 旧分支会保留,继续作为交互与测试参考;但它基于已经移除的 WinUI/P/Invoke 架构,不能安全 rebase 到当前 Rust/Tauri 主线。新实现保留了写入确认、PCM 准备、EBU R128、进度/取消、试听、安全另存为和路径安全等优势,同时贴合当前代码库。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
中文
用户可见变化
确认、安全与组件维护
~/.SynthVcopilot/output/ffmpeg;不会自动导入 SynthV、运行 CVRS、批处理或执行任意 FFmpeg 命令。Runtime 与架构
FfmpegService后台任务服务。pi-agent提交5cdb12f;对应依赖 PR:Restrict Agent FFmpeg tools to read-only inspection pi-agent#1。synthv-agent-bridge、IPC v3、sv_*工具和add_notes均未修改。验证
-D warnings通过。完整中英文记录见
CHANGELOG.md。English
User-visible changes
Confirmation, safety, and maintenance
~/.SynthVcopilot/output/ffmpeg; do not auto-import into SynthV, run CVRS, batch files, or expose arbitrary FFmpeg commands.PATHis never modified.Runtime and architecture
FfmpegService.pi-agentcommit5cdb12f; dependency PR: Restrict Agent FFmpeg tools to read-only inspection pi-agent#1.synthv-agent-bridge, IPC v3, thesv_*tools, andadd_notesunchanged.Validation
-D warnings.See
CHANGELOG.mdfor the complete bilingual release notes.