Convert template arg error fix - #18
Open
kingscallop wants to merge 2 commits into
Open
Conversation
When compiling to a x86-64 target using gcc, clang and msvc the following error appears:
In file included from spark/include/SPARK_Core.h:38,
from spark/src/Core/IO/SPK_IO_Buffer.cpp:22:
spark/include/Core/SPK_DescriptionDefines.h:266:123: error: could not convert template argument ‘&SPK::Group::getCapacity’ from ‘size_t (SPK::Group::*)() const’ {aka ‘long unsigned int (SPK::Group::*)() const’} to ‘unsigned int (SPK::Group::*)() const’
266 | ::template store<SPK_UNPACK_GETTERS_(_spk_obj,__VA_ARGS__)>,\
|
spark/include/Core/SPK_DescriptionDefines.h:154:25: note: in definition of macro ‘_spk_description_body’
154 | __VA_ARGS__ \
| ^~~~~~~~~~~
spark/include/Core/SPK_Group.h:373:25: note: in expansion of macro ‘spk_attribute’
373 | spk_attribute(unsigned int, capacity, reallocate, getCapacity);
| ^~~~~~~~~~~~~
On a x86-64 target (using those compilers) the size of size_t is 64bit and the size of
unsigned int is 32bit hence the 'could not convert' error.
The ParticleData struct field nbParticles was also set to unsigned int fix the packing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.