Skip to content

pull request - #5

Open
shelltdf wants to merge 5 commits into
Synxis:spark2from
shelltdf:spark2
Open

pull request #5
shelltdf wants to merge 5 commits into
Synxis:spark2from
shelltdf:spark2

Conversation

@shelltdf

Copy link
Copy Markdown

pull request

@Synxis

Synxis commented Jan 26, 2021

Copy link
Copy Markdown
Owner

Thanks for the participation !

As is, this PR cannot be accepted. Please separate it in several PRs:

  • one for your CMake improvements. BTW, there are several things that I don't really like:
    • what is "NIUBI" ?
    • the whole CMake config is currently obsolete, it would be nice to redo it entirely
    • no INSTALL rules, please
  • explain why going from size_t to unsigned int ?
  • changing the demos binaries should be an entire separate commit
  • don't change emit because of Qt. This change will always be refused; instead, please tell Qt not to define emit (and also signal btw)
  • why remove virtual ?

@shelltdf

Copy link
Copy Markdown
Author

in 32bit system size_t is 32bit. in 64bit system is 64bit. but *.spk file used on 32 and 64bit system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants