Repository navigation
fix(a11y): valid listbox in the artist search and readable pressed toggles - #4
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Each width is its own test (shared WIDTHS in layout-helpers), skipped outside the desktop project; drops test.slow() and the CI-only workers line. Longer waits on the examples map and the on-top check, which timed out under load. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ggles Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two accessibility issues that the per-width axe tests in #3 exposed in the Repertoire research's waiting step. Stacked on #3 (base
test/width-split); retarget tomainonce #3 merges.What changes
ArtistPicker): the status/alert lines and the note no longer sit inside cmdk'srole=listbox; they render beside it. The listbox renders only while it has options andaria-expandedfollows it, soaria-controlsnever points at an empty list. Fixes axearia-required-children. Keyboard behaviour unchanged.--primary-hovertoken (primary mixed 12% toward white) is used by thedefaultandposterbutton variants. Label contrast on hover: 6.19:1 light, 7.26:1 dark (was below AA on hover).Local checks before this push
--workers=2: 710 passed, 0 failed, 0 flaky, 208 skipped🤖 Generated with Claude Code